| commit | 2c613fa4b6be539b0e97933554dc1a24d18688f0 | [log] [tgz] |
|---|---|---|
| author | Arthur Hemery <[email protected]> | Mon Jan 08 09:36:32 2018 |
| committer | Commit Bot <[email protected]> | Mon Jan 08 10:47:13 2018 |
| tree | 79c61b050c2b517cfbdac11e3af62ad2e84cd700 | |
| parent | 9a2bc3fd179ff7db6e5f72a09a2e5a98b07e7d85 [diff] [blame] |
Navigation: Extracting UpdateHistory in its own function This CL aims to provide a separate function that handles history update during the commit process. Preparatory work for https://chromium-review.googlesource.com/c/chromium/src/+/789857 BUG=784904 Change-Id: Ia62eb3bad4f2a46aa19cdb1cf3d19522268e7182 Reviewed-on: https://chromium-review.googlesource.com/852454 Commit-Queue: Arthur Hemery <[email protected]> Reviewed-by: Camille Lamy <[email protected]> Cr-Commit-Position: refs/heads/master@{#527603}
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h index 2114e45..5030ef9 100644 --- a/content/renderer/render_frame_impl.h +++ b/content/renderer/render_frame_impl.h
@@ -1266,6 +1266,13 @@ // Updates the Zoom level of the render view to match current content. void UpdateZoomLevel(); + // Updates the navigation history depending on the passed parameters. + // This could result either in the creation of a new entry or a modification + // of the current entry or nothing. If a new entry was created, + // returns true, false otherwise. + bool UpdateNavigationHistory(const blink::WebHistoryItem& item, + blink::WebHistoryCommitType commit_type); + // Stores the WebLocalFrame we are associated with. This is null from the // constructor until BindToFrame() is called, and it is null after // FrameDetached() is called until destruction (which is asynchronous in the