Temporarily add safe_browsing to allow_circular_includes_from
Add //chrome/browser/safe_browsing to the allow_circular_includes_from
list for //chrome/browser/ui, and //chrome/browser/extensions. A real
solution would involve rather substantial refactoring of the Safe
Browsing code base. So do this to prevent build instability in the
meantime.
Bug: 919683, 925153
Change-Id: Iff0c9d0c67098c6255217721b55a390999e65737
Reviewed-on: https://chromium-review.googlesource.com/c/1436035
Commit-Queue: Daniel Rubery <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Istiaque Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/master@{#626280}diff --git a/chrome/browser/extensions/BUILD.gn b/chrome/browser/extensions/BUILD.gn
index 39c7e3b0..d00ff627 100644
--- a/chrome/browser/extensions/BUILD.gn
+++ b/chrome/browser/extensions/BUILD.gn
@@ -743,9 +743,13 @@
]
defines = []
- # TODO(loyso): Remove this circular dependency. http://crbug.com/876576.
- allow_circular_includes_from =
- [ "//chrome/browser/web_applications/extensions" ]
+ allow_circular_includes_from = [
+ # TODO(loyso): Remove this circular dependency. http://crbug.com/876576.
+ "//chrome/browser/web_applications/extensions",
+
+ # TODO(crbug/925153): Remove this circular dependency.
+ "//chrome/browser/safe_browsing",
+ ]
# Since browser and browser_extensions actually depend on each other,
# we must omit the dependency from browser_extensions to browser.
