| commit | 2ebd9254528fbf8967533c3a8520e3035c35ecc2 | [log] [tgz] |
|---|---|---|
| author | Sebastien Marchand <[email protected]> | Thu Nov 08 18:39:35 2018 |
| committer | Commit Bot <[email protected]> | Thu Nov 08 18:39:35 2018 |
| tree | ecd538cf4404baa770f78b6def84472ed07c375c | |
| parent | 5025d5931bd62db3abae530f257a9316fae3d6f1 [diff] |
Reland "RC: Encapsulate most of the singletons into ResourceCoordinatorParts" This is a reland of 14754da5c731fc8af079e5195209840492540e4d with some fixes (see the ps #1..#2 diff). The problem in the previous CL was that the LocalDB WCObserver was sometime created despite not having a PageSignalReceiver, this caused some access violation because this WCO relies on some signal sent by the PSR. I've added a check to prevent creating this WCO when the PSR isn't available (and fixed some tests to make them create one). // Confirmed with sky@ that he's ok with me relanding this without his // +1 as none of the files he owns have changed. [email protected] Original change's description: > RC: Encapsulate most of the singletons into ResourceCoordinatorParts > > There's several singletons / global instances in c/b/rc that are leaked > at shutdown, this is causing some issues in runs of unit_tests because > we end up re-using them between different test runs that should be > independent. This is currently preventing some feature to be enabled. > > This CL add a new ResourceCoordinatorParts class that encapsulate all > these objects that should be created only once, an instance of this > class is owned by the browser process. > > Change-Id: Ia64618b6f47052815d861ff6820d994f8a65cc64 > Reviewed-on: https://chromium-review.googlesource.com/c/1290775 > Reviewed-by: Scott Violet <[email protected]> > Reviewed-by: Chris Hamilton <[email protected]> > Reviewed-by: François Doray <[email protected]> > Commit-Queue: Sébastien Marchand <[email protected]> > Cr-Commit-Position: refs/heads/master@{#606061} Change-Id: I71feb4ea233d02cb5cc001c12e3cdd7f6ddd795b Reviewed-on: https://chromium-review.googlesource.com/c/1324134 Commit-Queue: Sébastien Marchand <[email protected]> Reviewed-by: François Doray <[email protected]> Cr-Commit-Position: refs/heads/master@{#606548}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .