Google Git
Sign in
chromium / chromium / src.git / 2ec2b4d16993605a9f46dd567fa8cfcf03612f86
commit2ec2b4d16993605a9f46dd567fa8cfcf03612f86[log] [tgz]
authorMichael Martis <[email protected]>Wed Dec 01 01:57:37 2021
committerChromium LUCI CQ <[email protected]>Wed Dec 01 01:57:37 2021
treea7535aa8c6a3e37380993d227b5fccd3d27b850a
parent4773e717fe2f7af54c99230f62195efa54813fa6 [diff]
[Snooping protection] Introduced HPS notify controller.

Snooping protection is now actively managing its preferences. Hence,
this CL moves its backend logic into a controller class that pushes
messages to its view. This has the added benefit of creating a
per-session (v.s. per display) location where future initialization etc.
logic can live.

The new unit test is actually a migration of the old view unit test
(since the controller is now responsible for most of the view's old
behavior). I've not added in new view tests, since the view now only
listens for colour and visibility changes. I can add in some tests for
that minor logic if you feel strongly.

Bug: chromium:1241704
Change-Id: Ieafdb1cf63c2e5437f2071b6cc7cb175de807173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3277223
Commit-Queue: Michael Martis <[email protected]>
Reviewed-by: James Cook <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Commit-Position: refs/heads/main@{#946819}
10 files changed
tree: a7535aa8c6a3e37380993d227b5fccd3d27b850a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.