commit 30fde829775645a5ced0a89a56c83cba6c5fd9b8
author marja@chromium.org <marja@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Fri Oct 28 09:49:05 2011
committer marja@chromium.org <marja@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Fri Oct 28 09:49:05 2011
tree 6d1a8bf29e6a4e12d4969d7b273620e151f99bef
parent 6cec7ee2e7ee985410f26b0700274aa92d0ad3a6

Adding CookieSettings for storing cookie content settings.

Moving cookie-spesific logic from HostContentSettingsMap to CookieSettings.
Making it explicit that the "is cookie session only" decision only depends on the
primary url.

Also removes the migration code for the obsolete kCookieBehavior preference.

BUG=93335
TEST=CookieSettings.*


Review URL: http://codereview.chromium.org/8383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107705 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/net/cookie_policy_browsertest.cc

diff --git a/chrome/browser/net/cookie_policy_browsertest.cc b/chrome/browser/net/cookie_policy_browsertest.cc
index 74e5eaa3..2128a15a 100644
--- a/chrome/browser/net/cookie_policy_browsertest.cc
+++ b/chrome/browser/net/cookie_policy_browsertest.cc
@@ -6,8 +6,10 @@
 #include "base/task.h"
 #include "base/synchronization/waitable_event.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
+#include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
+#include "chrome/common/pref_names.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "net/base/cookie_store.h"
@@ -80,8 +82,8 @@
 IN_PROC_BROWSER_TEST_F(CookiePolicyBrowserTest, AllowFirstPartyCookies) {
   ASSERT_TRUE(test_server()->Start());
 
-  browser()->profile()->GetHostContentSettingsMap()->
-      SetBlockThirdPartyCookies(true);
+  browser()->profile()->GetPrefs()->SetBoolean(prefs::kBlockThirdPartyCookies,
+                                               true);
 
   GURL url(test_server()->GetURL("set-cookie?cookie1"));
 
@@ -100,8 +102,8 @@
                        AllowFirstPartyCookiesRedirect) {
   ASSERT_TRUE(test_server()->Start());
 
-  browser()->profile()->GetHostContentSettingsMap()->
-      SetBlockThirdPartyCookies(true);
+  browser()->profile()->GetPrefs()->SetBoolean(prefs::kBlockThirdPartyCookies,
+                                               true);
 
   GURL url(test_server()->GetURL("server-redirect?"));
   GURL redirected_url(test_server()->GetURL("set-cookie?cookie2"));