| commit | 323efafeada25cc73ca76d4a1d6e00bd7bff42d4 | [log] [tgz] |
|---|---|---|
| author | Maks Orlovich <[email protected]> | Tue Mar 06 02:56:39 2018 |
| committer | Commit Bot <[email protected]> | Tue Mar 06 02:56:39 2018 |
| tree | 858f689043137e4d9646af98eb91450d97c76605 | |
| parent | f6663e43949ecb33976938c53fa2812a7e265b14 [diff] |
CookieMonster: Don't load entire cookie jar on SetCanonicalCookieAsync Before this change, the SQLite store and the cookie monster had different notions of how exactly |key| passed to PersistentStore::LoadCookiesForKey should be computed[1], and the version used by CookieMonster was not really computable from a CanonicalCookie. This changes both of these to use CookieMonster::GetKey, which is already used with both CanonicalCookie's and URLs, and can therefore be easily called from SetCanonicalCookieAsync as well. [1] In particular they disagreed on chrome-extension:// cookies, but that appeared to have been deterministically masked by implementation details of the SQLite cookie store, so doesn't seem to have been a bug that actually affected our users. Bug: 813141 Change-Id: Iaa3840a1e1e28992c99413142a62fddff97c7f78 Reviewed-on: https://chromium-review.googlesource.com/940141 Commit-Queue: Maks Orlovich <[email protected]> Reviewed-by: Victor Costan <[email protected]> Reviewed-by: Matt Menke <[email protected]> Cr-Commit-Position: refs/heads/master@{#541036}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .