| commit | 32967a9ec9ab2506e75e4e12e4e2ee6c19e339f9 | [log] [tgz] |
|---|---|---|
| author | Avi Drissman <[email protected]> | Thu Jul 30 04:10:32 2020 |
| committer | Commit Bot <[email protected]> | Thu Jul 30 04:10:32 2020 |
| tree | 655f43c55b7057cec88bd58051eb92d7c161660e | |
| parent | be4c444017c88d95a3ef03cce585ba34b0e78cee [diff] [blame] |
Engage the presubmit warning for OS_MACOSX OS_MACOSX will still work for code already in the tree, but warn to prevent new instances from landing. Bug: 1105907 Change-Id: Ia811e352ab7ec688bad5e8e7b31868777dd75c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328330 Commit-Queue: Avi Drissman <[email protected]> Commit-Queue: Dirk Pranke <[email protected]> Auto-Submit: Avi Drissman <[email protected]> Reviewed-by: Dirk Pranke <[email protected]> Cr-Commit-Position: refs/heads/master@{#793021}
diff --git a/PRESUBMIT_test.py b/PRESUBMIT_test.py index 8286775..111f2b2 100755 --- a/PRESUBMIT_test.py +++ b/PRESUBMIT_test.py
@@ -275,6 +275,7 @@ lines = ['#if defined(OS_WINDOWS)', ' #elif defined(OS_WINDOW)', ' # if defined(OS_MAC) || defined(OS_CHROME)', + '# else // defined(OS_MACOSX)', '#endif // defined(OS_MACOS)'] errors = PRESUBMIT._CheckForInvalidOSMacrosInFile( MockInputApi(), MockFile('some/path/foo_platform.cc', lines))