Google Git
Sign in
chromium / chromium / src.git / 35c203ac1851f3967d2fe9ba6e44bbbaa397e7d5
commit35c203ac1851f3967d2fe9ba6e44bbbaa397e7d5[log] [tgz]
authordanakj <[email protected]>Tue Apr 16 17:12:39 2019
committerCommit Bot <[email protected]>Tue Apr 16 17:12:39 2019
tree0804498b00340cdde2d7ff63dea4af4144750b26
parent3ddc529ed4fa3a98bdfec33dc3cc9b9231cf276f [diff]
Move SetAllowGpuRasterization from WebLayerTreeView to WebWidgetClient (11/n)

Rename the method to SetAllowGpuRasterization() to be much more
explicit about what the method does. Move the logic for deciding if
gpu raster is disallowed up to WebViewImpl, instead of splitting it
between WebViewImpl and ViewportDescription, since it is already
derivable from the ViewportDescription public API. And rewrite it with
and if statement to make it easier to follow.

Drops the branch on if (layer_tree_view_) for handling the commented
case 2 of doing layout after closing the WebWidget because I believe
that should be resolved by dcheng's solution here:
https://crrev.com/c/1416450/9..13/third_party/blink/renderer/core/frame/frame_test_helpers.cc

The WebLayerTreeView is a shortcut past the WebWidgetClient that is
not needed now that we always composite. This works toward eliminating
this extra API layer.

More importantly this helps us Close/Restart the WebWidget parts of
WebViewImpl by not requiring plumbing 2 pointers with slightly different
lifetimes (WebLayerTreeView is created inside the Init of the
WebWidgetClient). This will help avoid a bunch of complexity in
creating WebFrameWidgets and other WebWidgets.

[email protected]

Bug: 912193
Change-Id: I9278d80192a593f829915d3c1fc208b6a99a6d50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555354
Commit-Queue: danakj <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#651328}
12 files changed
tree: 0804498b00340cdde2d7ff63dea4af4144750b26
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .