Use helper macros to define base::Features in //net, part 1
This allows:
- features to be defined with a consistent set of qualifiers, and for
that set of qualifiers to be updated over time as appropriate.
- better PRESUBMIT checks to ensure that base::Features are not defined
in headers.
- simplifies things for scripts trying to extract feature definitions
out of C++ code.
The primary CL was generated using a script that automatically rewrites
base::Feature declarations and definitions to the macro form. Changes to
any files with known incompatibilities with the macros (base::Features
without static storage duration and base::Features declared as static
class members) were then fully reverted; those changes will be manually
handled in followups.
This is a manual cleanup pass that fixed several instances missed by the
original automation, since these use a non-standard export macro.
Bug: 1364289
Change-Id: Id611ded07f8c7c817f88dfd5ec938e936c38d722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3931306
Reviewed-by: Lei Zhang <[email protected]>
Auto-Submit: Daniel Cheng <[email protected]>
Owners-Override: Lei Zhang <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1053885}
diff --git a/net/disk_cache/cache_util.h b/net/disk_cache/cache_util.h
index 641f154..22da274 100644
--- a/net/disk_cache/cache_util.h
+++ b/net/disk_cache/cache_util.h
@@ -20,7 +20,7 @@
// Experiment to increase the cache size to see the impact on various
// performance metrics.
-NET_EXPORT_PRIVATE extern const base::Feature kChangeDiskCacheSizeExperiment;
+NET_EXPORT_PRIVATE BASE_DECLARE_FEATURE(kChangeDiskCacheSizeExperiment);
// Moves the cache files from the given path to another location.
// Fails if the destination exists already, or if it doesn't have
