| commit | 36aa8be4eb53b3ea75b84a9646e0204725f3bc43 | [log] [tgz] |
|---|---|---|
| author | olli.raula <[email protected]> | Thu Sep 10 11:14:22 2015 |
| committer | Commit bot <[email protected]> | Thu Sep 10 11:15:10 2015 |
| tree | 74da8174db2a6edd8d55cf141ec1976b3b37365d | |
| parent | 68fc3715f76e3da9131b035ddd9606dfee6180bd [diff] |
Move Singleton and related structs to namespace base
Public APIs from base should live inside base:: so moved Singleton class
and structs to base{} and fixed consumers.
also fixed:
** Presubmit ERRORS **
Found Singleton<T> in the following header files.
Please move them to an appropriate source file so that the template
gets instantiated in a single compilation unit.
chrome/browser/plugins/plugin_finder.h \
chromecast/media/base/media_message_loop.h \
content/browser/media/android/media_drm_credential_manager.h
Presubmit warnings:
src/chrome/browser/extensions/warning_badge_service_factory.h:5:
#ifndef header guard has wrong style, please use:
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_
[build/header_guard] [5]
src/chrome/browser/extensions/warning_badge_service_factory.h:39:
#endif line should be "#endif //
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_"
[build/header_guard] [5]
[email protected]
Review URL: https://codereview.chromium.org/1308823002
Cr-Commit-Position: refs/heads/master@{#348136}