| commit | 37852efeabc63dc5fa0ce2d0ad8ef3885be3b6c0 | [log] [tgz] |
|---|---|---|
| author | Steven Bennetts <[email protected]> | Wed Mar 06 00:32:23 2019 |
| committer | Commit Bot <[email protected]> | Wed Mar 06 00:32:23 2019 |
| tree | 287809c118223e8feb1637bd9f92b79f4ae2b8da | |
| parent | 02ab4dd4e37dad1686ab90fdd9d53106f5168b20 [diff] |
Make chromeos/{dbus/}constants components
The constants subdirectories were inadvertently defined as source sets,
even though they are included by mulitiple libraries. This causes
ODR violations in asan component builds.
Sinces these are just constants it should not affect any runtime
behavior.
This CL also adds a BUILD.gn file to each subdir and cleans up a few
unnecessary dependencies.
For mechanical BUILD.gn changes:
[email protected]
Bug: 933063
Change-Id: I05195779ddd606c4ad33ae7c1c713044a8cb089e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495862
Reviewed-by: Dan Erat <[email protected]>
Reviewed-by: Pavol Marko <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Auto-Submit: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/heads/master@{#637924}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .