Use more URL constants throughout browser_tests
This change eliminates several dependencies on hardcoded URL strings
thoughout test code that builds into browser_tests.exe.
For native test code, string hardcodes were mostly replaced by
additional usages of content::GetWebUIURL* utility functions and
chrome/content URL constants.
Bug: 955562
Change-Id: Idc6c466ec4321030fb3526c2f29ee187a5faa11d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591372
Reviewed-by: Ben Wells <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Matt Siembor <[email protected]>
Cr-Commit-Position: refs/heads/master@{#657406}
diff --git a/chrome/browser/extensions/permissions_test_util.cc b/chrome/browser/extensions/permissions_test_util.cc
index 4333f3f..f7b6973 100644
--- a/chrome/browser/extensions/permissions_test_util.cc
+++ b/chrome/browser/extensions/permissions_test_util.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/extensions/permissions_test_util.h"
#include "base/run_loop.h"
+#include "chrome/common/webui_url_constants.h"
#include "content/public/browser/browser_context.h"
#include "extensions/common/extension.h"
#include "extensions/common/permissions/permission_set.h"
@@ -21,7 +22,7 @@
// the extension to retrieve a favicon for a given URL). Just ignore it when
// generating host sets.
std::string pattern_string = pattern.GetAsString();
- if (pattern_string != "chrome://favicon/*")
+ if (pattern_string != std::string(chrome::kChromeUIFaviconURL) + "*")
pattern_strings.push_back(pattern_string);
}
