Move sockets to CompletionOnceCallbacks
changes Socket::Read(), Socket::ReadIfRead(), Socket::Write(), StreamSocket::Connect(), SocketPosix::Accept() & SocketPosix::Connect() to CompletionOnceCallback.
[email protected], [email protected], [email protected], [email protected]
Bug: 807724
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia363b632bf1193c40576e3ccdd93188081aca589
Reviewed-on: https://chromium-review.googlesource.com/907076
Commit-Queue: Brad Lassey <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: mark a. foltz <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Reviewed-by: Stephen Lanham <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Bence Béky <[email protected]>
Cr-Commit-Position: refs/heads/master@{#553894}diff --git a/net/socket/ssl_client_socket_impl.h b/net/socket/ssl_client_socket_impl.h
index cd7b7c1..a6285fd 100644
--- a/net/socket/ssl_client_socket_impl.h
+++ b/net/socket/ssl_client_socket_impl.h
@@ -90,7 +90,7 @@
unsigned int outlen) override;
// StreamSocket implementation.
- int Connect(const CompletionCallback& callback) override;
+ int Connect(CompletionOnceCallback callback) override;
void Disconnect() override;
bool IsConnected() const override;
bool IsConnectedAndIdle() const override;
@@ -125,13 +125,13 @@
// Socket implementation.
int Read(IOBuffer* buf,
int buf_len,
- const CompletionCallback& callback) override;
+ CompletionOnceCallback callback) override;
int ReadIfReady(IOBuffer* buf,
int buf_len,
- const CompletionCallback& callback) override;
+ CompletionOnceCallback callback) override;
int Write(IOBuffer* buf,
int buf_len,
- const CompletionCallback& callback,
+ CompletionOnceCallback callback,
const NetworkTrafficAnnotationTag& traffic_annotation) override;
int SetReceiveBufferSize(int32_t size) override;
int SetSendBufferSize(int32_t size) override;
@@ -241,9 +241,9 @@
const crypto::OpenSSLErrStackTracer& tracer,
OpenSSLErrorInfo* info);
- CompletionCallback user_connect_callback_;
- CompletionCallback user_read_callback_;
- CompletionCallback user_write_callback_;
+ CompletionOnceCallback user_connect_callback_;
+ CompletionOnceCallback user_read_callback_;
+ CompletionOnceCallback user_write_callback_;
// Used by Read function.
scoped_refptr<IOBuffer> user_read_buf_;
