PRESUBMIT: Bark about DISALLOW_* macros without #include "base/macros.h"
I'm sick of enforcing this in like every code review.
[email protected],[email protected]
[email protected]
BUG=none
TEST=PRESUBMIT_test.py
Review URL: https://codereview.chromium.org/1411553003
Cr-Commit-Position: refs/heads/master@{#354607}
diff --git a/PRESUBMIT_test.py b/PRESUBMIT_test.py
index 4d40d8f..f5a21ca 100755
--- a/PRESUBMIT_test.py
+++ b/PRESUBMIT_test.py
@@ -413,6 +413,43 @@
self.assertEqual(0, len(warnings))
+class CheckBaseMacrosInHeadersTest(unittest.TestCase):
+ def _make_h(self, macro, header):
+ return ("""
+#include "base/%s.h"
+
+class Thing {
+ private:
+ DISALLOW_%s(Thing);
+};
+""" % (macro, header)).splitlines()
+
+ def testBaseMacrosInHeadersBad(self):
+ mock_input_api = MockInputApi()
+ mock_input_api.files = [
+ MockAffectedFile('foo.h', self._make_h('not_macros', 'ASSIGN')),
+ MockAffectedFile('bar.h', self._make_h('not_macros', 'COPY')),
+ MockAffectedFile('baz.h', self._make_h('not_macros', 'COPY_AND_ASSIGN')),
+ MockAffectedFile('qux.h', self._make_h('not_macros', 'EVIL')),
+ ]
+ warnings = PRESUBMIT._CheckBaseMacrosInHeaders(mock_input_api,
+ MockOutputApi())
+ self.assertEqual(1, len(warnings))
+ self.assertEqual(4, len(warnings[0].items))
+
+ def testBaseMacrosInHeadersGood(self):
+ mock_input_api = MockInputApi()
+ mock_input_api.files = [
+ MockAffectedFile('foo.h', self._make_h('macros', 'ASSIGN')),
+ MockAffectedFile('bar.h', self._make_h('macros', 'COPY')),
+ MockAffectedFile('baz.h', self._make_h('macros', 'COPY_AND_ASSIGN')),
+ MockAffectedFile('qux.h', self._make_h('macros', 'EVIL')),
+ ]
+ warnings = PRESUBMIT._CheckBaseMacrosInHeaders(mock_input_api,
+ MockOutputApi())
+ self.assertEqual(0, len(warnings))
+
+
class InvalidOSMacroNamesTest(unittest.TestCase):
def testInvalidOSMacroNames(self):
lines = ['#if defined(OS_WINDOWS)',
