[gcc] Fix compiler warning turned into errors with gcc while compiling extension_sync_data_unittest.cc
With gcc toolchain, we get following error with EXPECT_FALSE
error: converting ‘false’ to pointer type for argument 1 of
‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Werror=conversion-null]
Changing EXPECT_EQ(...) to EXPECT_FALSE() fixes the error.
[email protected], [email protected]
Review URL: https://codereview.chromium.org/928003002
Cr-Commit-Position: refs/heads/master@{#316587}
diff --git a/chrome/browser/extensions/extension_sync_data_unittest.cc b/chrome/browser/extensions/extension_sync_data_unittest.cc
index bd4e9ee..4236502 100644
--- a/chrome/browser/extensions/extension_sync_data_unittest.cc
+++ b/chrome/browser/extensions/extension_sync_data_unittest.cc
@@ -97,9 +97,9 @@
extension_sync_data.PopulateFromExtensionSpecifics(*extension_specifics);
EXPECT_EQ(kValidId, extension_sync_data.id());
EXPECT_EQ(GURL(kValidUpdateUrl), extension_sync_data.update_url());
- EXPECT_EQ(false, extension_sync_data.enabled());
+ EXPECT_FALSE(extension_sync_data.enabled());
EXPECT_EQ(true, extension_sync_data.incognito_enabled());
- EXPECT_EQ(false, extension_sync_data.remote_install());
+ EXPECT_FALSE(extension_sync_data.remote_install());
EXPECT_EQ(ExtensionSyncData::BOOLEAN_TRUE,
extension_sync_data.all_urls_enabled());
EXPECT_TRUE(Version(kVersion).Equals(extension_sync_data.version()));
@@ -118,7 +118,7 @@
extension_sync_data.PopulateFromExtensionSpecifics(*extension_specifics);
EXPECT_EQ(ExtensionSyncData::BOOLEAN_FALSE,
extension_sync_data.all_urls_enabled());
- EXPECT_EQ(false, extension_sync_data.incognito_enabled());
+ EXPECT_FALSE(extension_sync_data.incognito_enabled());
SyncDataToProtobufEqual(extension_sync_data);
