commit 3bc7779ba002f50675a18e2eae277d4617788e21
author tzik <tzik@chromium.org> Sat Dec 19 09:18:46 2015
committer Commit bot <commit-bot@chromium.org> Sat Dec 19 09:20:02 2015
tree b7d1186e90b289ea7c101cbc316e7214e4f5a007
parent 7131453f358de5c014fbb709ef5c15985621849e

Replace typedef with using for Callback/Bind related files

This CL contains:
 * Replace typedef with using.
 * Remove |void| from no-parameter function declarations.
 * Fix an error in a comment.

BUG=

Review URL: https://codereview.chromium.org/1537553002

Cr-Commit-Position: refs/heads/master@{#366278}

base/bind_unittest.nc

diff --git a/base/bind_unittest.nc b/base/bind_unittest.nc
index 70c479f0..10d2c80d 100644
--- a/base/bind_unittest.nc
+++ b/base/bind_unittest.nc
@@ -29,8 +29,8 @@
 
 class Parent {
  public:
-  void AddRef(void) const {}
-  void Release(void) const {}
+  void AddRef() const {}
+  void Release() const {}
   virtual void VirtualSet() { value = kParentValue; }
   void NonVirtualSet() { value = kParentValue; }
   int value;
@@ -75,7 +75,7 @@
 void WontCompile() {
   HasRef has_ref;
   const HasRef* const_has_ref_ptr_ = &has_ref;
-  Callback<void(void)> method_to_const_cb =
+  Callback<void()> method_to_const_cb =
       Bind(&HasRef::VoidMethod0, const_has_ref_ptr_);
   method_to_const_cb.Run();
 }
@@ -87,7 +87,7 @@
 // We require refcounts unless you have Unretained().
 void WontCompile() {
   NoRef no_ref;
-  Callback<void(void)> no_ref_cb =
+  Callback<void()> no_ref_cb =
       Bind(&NoRef::VoidMethod0, &no_ref);
   no_ref_cb.Run();
 }
@@ -99,7 +99,7 @@
 // We require refcounts unless you have Unretained().
 void WontCompile() {
   NoRef no_ref;
-  Callback<void(void)> no_ref_const_cb =
+  Callback<void()> no_ref_const_cb =
       Bind(&NoRef::VoidConstMethod0, &no_ref);
   no_ref_const_cb.Run();
 }
@@ -111,7 +111,7 @@
 // This is just a const-correctness check.
 void WontCompile() {
   const NoRef* const_no_ref_ptr;
-  Callback<NoRef*(void)> pointer_same_cb =
+  Callback<NoRef*()> pointer_same_cb =
       Bind(&PolymorphicIdentity<NoRef*>, const_no_ref_ptr);
   pointer_same_cb.Run();
 }
@@ -123,7 +123,7 @@
 // This is just a const-correctness check.
 void WontCompile() {
   const NoRefChild* const_child_ptr;
-  Callback<NoRefParent*(void)> pointer_super_cb =
+  Callback<NoRefParent*()> pointer_super_cb =
     Bind(&PolymorphicIdentity<NoRefParent*>, const_child_ptr);
   pointer_super_cb.Run();
 }
@@ -152,7 +152,7 @@
 // See comment in NCTEST_DISALLOW_NON_CONST_REF_PARAM
 void WontCompile() {
   Parent p;
-  Callback<int(void)> ref_cb = Bind(&UnwrapParentRef, p);
+  Callback<int()> ref_cb = Bind(&UnwrapParentRef, p);
   ref_cb.Run();
 }
 
@@ -165,7 +165,7 @@
 // implicitly convert an array type to a pointer type.
 void WontCompile() {
   HasRef p[10];
-  Callback<void(void)> method_bound_to_array_cb =
+  Callback<void()> method_bound_to_array_cb =
       Bind(&HasRef::VoidMethod0, p);
   method_bound_to_array_cb.Run();
 }
@@ -176,9 +176,9 @@
 void WontCompile() {
   HasRef for_raw_ptr;
   int a;
-  Callback<void(void)> ref_count_as_raw_ptr_a =
+  Callback<void()> ref_count_as_raw_ptr_a =
       Bind(&VoidPolymorphic1<int*>, &a);
-  Callback<void(void)> ref_count_as_raw_ptr =
+  Callback<void()> ref_count_as_raw_ptr =
       Bind(&VoidPolymorphic1<HasRef*>, &for_raw_ptr);
 }
 
@@ -188,7 +188,7 @@
 void WontCompile() {
   NoRef no_ref;
   WeakPtrFactory<NoRef> weak_factory(&no_ref);
-  Callback<int(void)> weak_ptr_with_non_void_return_type =
+  Callback<int()> weak_ptr_with_non_void_return_type =
       Bind(&NoRef::IntMethod0, weak_factory.GetWeakPtr());
   weak_ptr_with_non_void_return_type.Run();
 }