Expose TLS settings in the Security panel overview, and call out individual obsolete settings.
BUG=551728
TEST=For all tests below, first open DevTools to the Security panel overview.
1) Visit google.com and check that there is a green bullet point with
the following summary and description:
- Secure Connection
- The connection to this site is encrypted and authenticated using a strong protocol (QUIC), a strong key exchange (ECDHE_RSA), and a strong cipher (AES_128_GCM).
2) Visit cbc.badssl.com and check that there is a gray info bullet
point with the following summary and description:
- Obsolete Connection Settings
- The connection to this site uses a strong protocol (TLS 1.2), a strong key exchange (ECDHE_RSA), and an obsolete cipher (AES_256_CBC with HMAC-SHA1).
3) Visit cbc.badssl.com/mixed/script/ and check that there are two gray
info bullet points: "Obsolete TLS cipher suite" and
"Blocked mixed content".
4) Visit static-rsa.badssl.com and check that there is a gray info bullet point
with the following summary and description:
- Obsolete Connection Settings
- The connection to this site uses a strong protocol (TLS 1.2), an obsolete key exchange (RSA), and a strong cipher (AES_256_GCM).
5) Visit https://tls-v1-0.badssl.com:1010/ and check that there is a gray info
bullet point with the following summary and description:
- Obsolete Connection Settings
- The connection to this site uses an obsolete protocol (TLS 1.0), a strong key exchange (ECDHE_RSA), and an obsolete cipher (AES_128_CBC with HMAC-SHA1).
Review-Url: https://codereview.chromium.org/1727133002
Cr-Commit-Position: refs/heads/master@{#414341}
diff --git a/chrome/browser/ui/website_settings/website_settings.cc b/chrome/browser/ui/website_settings/website_settings.cc
index 1a078b5..4dca5173 100644
--- a/chrome/browser/ui/website_settings/website_settings.cc
+++ b/chrome/browser/ui/website_settings/website_settings.cc
@@ -591,7 +591,7 @@
} else {
site_connection_status_ = SITE_CONNECTION_STATUS_ENCRYPTED;
- if (security_info.is_secure_protocol_and_ciphersuite) {
+ if (security_info.obsolete_ssl_status == net::OBSOLETE_SSL_NONE) {
site_connection_details_.assign(l10n_util::GetStringFUTF16(
IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_CONNECTION_TEXT,
subject_name));
