Convert ShowCreatedWindow into blink mojom messages.
ShowCreatedWindow becomes a message on the FrameWidgetHost
channel that was previously created frame widget to be shown.
Note that this new message is on the LocalMainFrame of the new
window, previously it was sent to the opener of the window.
Previously a WidgetMsg_SetBounds_ACK was sent after the
ShowCreatedWindow message was received this turns
into a mojom callback.
BUG=1097816
Change-Id: I43a9cc57c9039f94648ea5dc918b5951d0d7dbdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487843
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: danakj <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/heads/master@{#820819}
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 329af00..161f911 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -185,8 +185,7 @@
RenderViewImpl* render_view,
CompositorDependencies* compositor_deps,
blink::WebFrame* opener,
- mojom::CreateViewParamsPtr* params,
- RenderWidget::ShowCallback show_callback);
+ mojom::CreateViewParamsPtr* params);
// Creates a new RenderFrame with |routing_id|. If |previous_routing_id| is
// MSG_ROUTING_NONE, it creates the Blink WebLocalFrame and inserts it into
@@ -335,12 +334,6 @@
// gone, and clean up code that depends on it.
bool in_frame_tree() { return in_frame_tree_; }
- // A RenderView opened by this RenderFrame needs to be shown.
- void ShowCreatedWindow(bool opened_by_user_gesture,
- RenderWidget* render_widget_to_show,
- blink::WebNavigationPolicy policy,
- const gfx::Rect& initial_rect);
-
#if BUILDFLAG(ENABLE_PLUGINS)
// Notification that a PPAPI plugin has been created.
void PepperPluginCreated(RendererPpapiHost* host);
