[omnibox] Add a flag for changing display color of navigation suggestions.
This CL adds two chrome://flags flags for crrev.com/c/1475065.
Bug: 931836
Change-Id: I513f988e36c853383c41f48b1ed0841a5ca10b60
Reviewed-on: https://chromium-review.googlesource.com/c/1481904
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Kevin Bailey <[email protected]>
Commit-Queue: manuk hovanesian <[email protected]>
Cr-Commit-Position: refs/heads/master@{#634712}diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index e34b693..e47c714 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -3005,6 +3005,20 @@
kOsDesktop,
FEATURE_VALUE_TYPE(omnibox::kUIExperimentBlueSearchLoopAndSearchQuery)},
+ {"omnibox-ui-blue-titles-and-gray-urls-on-page-suggestions",
+ flag_descriptions::kOmniboxUIBlueTitlesAndGrayUrlsOnPageSuggestionsName,
+ flag_descriptions::
+ kOmniboxUIBlueTitlesAndGrayUrlsOnPageSuggestionsDescription,
+ kOsDesktop,
+ FEATURE_VALUE_TYPE(
+ omnibox::kUIExperimentBlueTitlesAndGrayUrlsOnPageSuggestions)},
+
+ {"omnibox-ui-blue-titles-on-page-suggestions",
+ flag_descriptions::kOmniboxUIBlueTitlesOnPageSuggestionsName,
+ flag_descriptions::kOmniboxUIBlueTitlesOnPageSuggestionsDescription,
+ kOsDesktop,
+ FEATURE_VALUE_TYPE(omnibox::kUIExperimentBlueTitlesOnPageSuggestions)},
+
{"omnibox-ui-use-generic-search-engine-icon",
flag_descriptions::kOmniboxUIUseGenericSearchEngineIconName,
flag_descriptions::kOmniboxUIUseGenericSearchEngineIconDescription,
diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
index 18d7e97..d5ada9d 100644
--- a/chrome/browser/flag-metadata.json
+++ b/chrome/browser/flag-metadata.json
@@ -2573,6 +2573,16 @@
"expiry_milestone": 80
},
{
+ "name": "omnibox-ui-blue-titles-and-gray-urls-on-page-suggestions",
+ "owners": [ "tommycli", "[email protected]" ],
+ "expiry_milestone": 80
+ },
+ {
+ "name": "omnibox-ui-blue-titles-on-page-suggestions",
+ "owners": [ "tommycli", "[email protected]" ],
+ "expiry_milestone": 80
+ },
+ {
"name": "omnibox-ui-use-generic-search-engine-icon",
"owners": [ "tommycli", "[email protected]" ],
"expiry_milestone": 80
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
index 99f82c1c..b9c388f 100644
--- a/chrome/browser/flag_descriptions.cc
+++ b/chrome/browser/flag_descriptions.cc
@@ -1363,6 +1363,16 @@
const char kOmniboxUIBlueSearchLoopAndSearchQueryDescription[] =
"Color the generic search icon and search terms blue.";
+const char kOmniboxUIBlueTitlesAndGrayUrlsOnPageSuggestionsName[] =
+ "Omnibox UI Blue Titles And Gray Urls On Page Suggestions";
+const char kOmniboxUIBlueTitlesAndGrayUrlsOnPageSuggestionsDescription[] =
+ "Displays navigation suggestions with blue titles and gray URLs.";
+
+const char kOmniboxUIBlueTitlesOnPageSuggestionsName[] =
+ "Omnibox UI Blue Titles On Page Suggestions";
+const char kOmniboxUIBlueTitlesOnPageSuggestionsDescription[] =
+ "Displays navigation suggestions with blue titles.";
+
const char kOmniboxUIHideSteadyStateUrlSchemeName[] =
"Omnibox UI Hide Steady-State URL Scheme";
const char kOmniboxUIHideSteadyStateUrlSchemeDescription[] =
diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
index 6e01148..f4b277d 100644
--- a/chrome/browser/flag_descriptions.h
+++ b/chrome/browser/flag_descriptions.h
@@ -828,6 +828,12 @@
extern const char kOmniboxUIBlueSearchLoopAndSearchQueryName[];
extern const char kOmniboxUIBlueSearchLoopAndSearchQueryDescription[];
+extern const char kOmniboxUIBlueTitlesAndGrayUrlsOnPageSuggestionsName[];
+extern const char kOmniboxUIBlueTitlesAndGrayUrlsOnPageSuggestionsDescription[];
+
+extern const char kOmniboxUIBlueTitlesOnPageSuggestionsName[];
+extern const char kOmniboxUIBlueTitlesOnPageSuggestionsDescription[];
+
extern const char kOmniboxUIHideSteadyStateUrlSchemeName[];
extern const char kOmniboxUIHideSteadyStateUrlSchemeDescription[];
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
index c91352c4..1d45328 100644
--- a/tools/metrics/histograms/enums.xml
+++ b/tools/metrics/histograms/enums.xml
@@ -31659,6 +31659,8 @@
<int value="-671992446" label="TranslateRankerEnforcement:disabled"/>
<int value="-670188266" label="enable-zip-archiver-unpacker"/>
<int value="-667517406" label="overscroll-history-navigation"/>
+ <int value="-667018797"
+ label="OmniboxUIExperimentBlueTitlesAndGrayUrlsOnPageSuggestions:disabled"/>
<int value="-666508951" label="CrOSContainer:enabled"/>
<int value="-663476391" label="enable-pixel-canvas-recording:enabled"/>
<int value="-662064703" label="MediaSessionService:enabled"/>
@@ -31698,6 +31700,8 @@
<int value="-599932554" label="DoodlesOnLocalNtp:disabled"/>
<int value="-598050737" label="disable-es3-apis"/>
<int value="-596337171" label="disable-ash-sidebar"/>
+ <int value="-595819071"
+ label="OmniboxUIExperimentBlueTitlesOnPageSuggestions:disabled"/>
<int value="-593536514" label="ExperimentalTabController:enabled"/>
<int value="-592331266" label="ForegroundNotificationManager:enabled"/>
<int value="-589096918" label="ash-enable-fullscreen-app-list"/>
@@ -31795,6 +31799,8 @@
<int value="-408769228" label="ArcGraphicBuffersVisualizationTool:disabled"/>
<int value="-406850932" label="EnableEmojiContextMenu:enabled"/>
<int value="-405380243" label="enable-encryption-migration"/>
+ <int value="-402038055"
+ label="OmniboxUIExperimentBlueTitlesAndGrayUrlsOnPageSuggestions:enabled"/>
<int value="-401170566"
label="OmniboxUIExperimentHideSuggestionUrlPath:disabled"/>
<int value="-400584764" label="ChromeHomeNtpRedesign:enabled"/>
@@ -32627,6 +32633,8 @@
<int value="1049885154" label="OfflinePagesPrefetching:disabled"/>
<int value="1050048304" label="enable-font-cache-scaling"/>
<int value="1050321458" label="new-profile-management"/>
+ <int value="1050442356"
+ label="OmniboxUIExperimentBlueTitlesOnPageSuggestions:enabled"/>
<int value="1050664817" label="CSSFragmentIdentifiers:enabled"/>
<int value="1053743655" label="NewOverviewAnimations:enabled"/>
<int value="1054910800" label="enable-timezone-tracking-option"/>
