Google Git
Sign in
chromium / chromium / src.git / e7de93acbf318734823819f49180d5bdd6bcb007
commite7de93acbf318734823819f49180d5bdd6bcb007[log] [tgz]
authorGiovanni Ortuño Urquidi <[email protected]>Tue Jun 02 06:32:41 2020
committerCommit Bot <[email protected]>Tue Jun 02 06:32:41 2020
tree06093c9ee77c5f4958ab4888f5c508cac4d0a7d3
parent34a841642accc8b85776cd5fce4a52aa736f75a6 [diff]
Revert "[SB Delayed Warnings] Allow non-character keys such as Escape"

This reverts commit e00873cbc25008afdfb83f02f1206cd505573610.

Reason for revert: Causing a lot of
SafeBrowsingBlockingPageDelayedWarningBrowserTest tests to fail:

https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/63042

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878647092646084928/+/steps/browser_tests/0/logs/Deterministic_failure:_SafeBrowsingBlockingPageWithDelayedWarningsBrowserTest__x2f_SafeBrowsingBlockingPageDelayedWarningBrowserTest.KeyPress_ESCAndCharacterKey_WarningShown__x2f_1__status_CRASH_/0


Original change's description:
> [SB Delayed Warnings] Allow non-character keys such as Escape
> 
> Users may sometimes press non character keys such as ESC when on a
> webpage (e.g. to close popups or other prompts). This CL ignores
> these cases and does not undelay the warning.
> 
> Bug: 1057157
> Change-Id: I4cfc2c621e4c0a84f46fdaa8f800e6843ed6b4b4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225361
> Commit-Queue: Mustafa Emre Acer <[email protected]>
> Reviewed-by: Varun Khaneja <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#773833}

[email protected],[email protected]

Change-Id: I660f1e2b2b05472df75fbe34600672d53594e95e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1057157
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225682
Reviewed-by: Giovanni Ortuño Urquidi <[email protected]>
Commit-Queue: Giovanni Ortuño Urquidi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#774033}
2 files changed
tree: 06093c9ee77c5f4958ab4888f5c508cac4d0a7d3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.