| commit | 4496d0822a40dc1813e610828062783e397504b3 | [log] [tgz] |
|---|---|---|
| author | Daniel Cheng <[email protected]> | Thu Apr 26 21:52:15 2018 |
| committer | Commit Bot <[email protected]> | Thu Apr 26 21:52:15 2018 |
| tree | 6bf15b3dce177a91f02cc473e4697ada6109fa73 | |
| parent | fec224f259d340b9316e9960b99a0efe616b4bfd [diff] [blame] |
Chrome style plugin: enable virtual specifier checks for Gmock objects in //net Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //net. Bug: 837148 Change-Id: I9f65b485272c931b18d4c5851ec7c29327b4f40b Reviewed-on: https://chromium-review.googlesource.com/1031192 Reviewed-by: Matt Mueller <[email protected]> Commit-Queue: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/master@{#554161}
diff --git a/net/websockets/websocket_basic_stream_adapters_test.cc b/net/websockets/websocket_basic_stream_adapters_test.cc index f7246c8..3c6e882f 100644 --- a/net/websockets/websocket_basic_stream_adapters_test.cc +++ b/net/websockets/websocket_basic_stream_adapters_test.cc
@@ -287,7 +287,7 @@ class MockDelegate : public WebSocketSpdyStreamAdapter::Delegate { public: - virtual ~MockDelegate() = default; + ~MockDelegate() override = default; MOCK_METHOD0(OnHeadersSent, void()); MOCK_METHOD1(OnHeadersReceived, void(const SpdyHeaderBlock&)); MOCK_METHOD1(OnClose, void(int));