Remove SSLStatus::security_style member and content::SecurityStyle
Previously, //content used SSLStatus::security_style to express an
opinion about the overall security state of the
page. SecurityStateModel/ChromeSecurityStateModelClient used this
SecurityStyle as a starting point, applying Chrome-specific policies
such as SHA1 deprecation to produce a SecurityLevel, which corresponds
to the lock icon. Then, for conveying the security state of a page back
to DevTools, the SecurityLevel would get converted back into a
SecurityStyle (often a different SecurityStyle than what //content
assigned in SSLStatus::security_style). Additionally, SecurityStyles are
used to convey per-request security info to DevTools.
This CL removes SSLStatus::security_style, so that //content no longer
assigns an overall security state to a page. This means that
SecurityStyles are now only used to convey security
information (per-page or per-request) to DevTools. We only convert from
SecurityLevels to SecurityStyles, and never the other way around.
Since content::SecurityStyle no longer serves any purpose besides
ferrying information to devtools, I removed content::SecurityStyle and
just use blink::WebSecurityStyle everywhere (which has been pulled out
into its own file, from blink::WebURLResponse::SecurityStyle).
This should hopefully make SecurityLevel/SecurityStyle less confusing,
and remove the temptation to use SSLStatus::security_style
as an indicator of overall page security state instead of the
embedder-specific SecurityLevel.
BUG=648326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2400673003
Cr-Commit-Position: refs/heads/master@{#424436}
diff --git a/chrome/browser/DEPS b/chrome/browser/DEPS
index fa880ce..7bf8e774 100644
--- a/chrome/browser/DEPS
+++ b/chrome/browser/DEPS
@@ -89,6 +89,7 @@
"+third_party/WebKit/public/platform/WebDisplayMode.h",
"+third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h",
"+third_party/WebKit/public/platform/WebReferrerPolicy.h",
+ "+third_party/WebKit/public/platform/WebSecurityStyle.h",
"+third_party/WebKit/public/platform/modules/app_banner/WebAppBannerPromptReply.h",
"+third_party/WebKit/public/platform/modules/budget_service/budget_service.mojom.h",
"+third_party/WebKit/public/platform/modules/notifications/WebNotificationConstants.h",
