Reland "Use standard ExternalProtocolDialog in Chrome OS for Guest OS apps"
This reverts commit e739fc504bf09d3eb1bf435a50eff6b82e401e0c.
Reason for revert:
reland with fix for camera.CCAUISettings in crrev.com/c/2454769
Original change's description:
> Revert "Use standard ExternalProtocolDialog in Chrome OS for Guest OS apps"
>
> This reverts commit 4d4f20fc410838c9dc607695c57ee9e349803412.
>
> Reason for revert: https://crbug.com/1132535
>
> Original change's description:
> > Use standard ExternalProtocolDialog in Chrome OS for Guest OS apps
> >
> > Screenshots:
> > http://go/chrome-ss/0a0bc6ca1f1985c5c25a726a8ef123c27c33c7e1
> > http://go/chrome-ss/bd6f5d9d4ef33bd9ae8addb575c88dd2a1d04818
> > http://go/chrome-ss/d4b444ab2d88cb4bd11e21e52b7246de60c8bf71
> >
> > When Chrome OS did not support external protocol handlers, it
> > replaced browser/ui/views/external_protocol_dialog with
> > browser/chromeos/external_protocol_dialog which states that no
> > handlers are available. ARC has added a dialog which is shown
> > when any android apps can handle a link. This CL uses the
> > standard ExternalProtocolDialog for Guest OS apps when ARC does
> > not handle a link, but Guest OS can.
> >
> > * Renamed CrOS version of ExternalProtocolDialog to
> > ExternalProtocolNoHandlersDialog. It is still used when no handlers
> > are found.
> >
> > * Changed ui/views/external_protocol_dialog to now be compiled into
> > CrOS, but leaving out
> > ExternalProtocolHandler::RunExternalProtocolDialog which is provided
> > in the CrOS version: chromeos/external_protocol_dialog.cc.
> >
> > * Replaced platform_util_chromeos OpenExternal to Launch the registered
> > Guest OS app. This function was previously not ever called in CrOS.
> >
> > Bug: b/168506505
> > Change-Id: I89ffd84b9308cb2ce4b7e0691183e0da3402a4cc
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423675
> > Commit-Queue: Joel Hockey <[email protected]>
> > Reviewed-by: Elly Fong-Jones <[email protected]>
> > Reviewed-by: Lei Zhang <[email protected]>
> > Reviewed-by: Xiyuan Xia <[email protected]>
> > Reviewed-by: Jason Lin <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#810381}
>
> [email protected],[email protected],[email protected],[email protected],[email protected]
>
>
> Bug: b/168506505,1132535
> Skip-Translation-Screenshots-Check: True
> Change-Id: I52bfc2a8169a018076790df8a63c253c29ded64c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434014
> Commit-Queue: Jason Lin <[email protected]>
> Reviewed-by: Jason Lin <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#811144}
[email protected],[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: b/168506505
Bug: 1132535
Change-Id: Iebea2aeaad1cddae89c96fcbefab49c96152927f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454350
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Joel Hockey <[email protected]>
Commit-Queue: Joel Hockey <[email protected]>
Cr-Commit-Position: refs/heads/master@{#814487}
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 48eaac4b..ba92d614 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -3031,6 +3031,10 @@
{"crostini-enable-dlc", flag_descriptions::kCrostiniEnableDlcName,
flag_descriptions::kCrostiniEnableDlcDescription, kOsCrOS,
FEATURE_VALUE_TYPE(chromeos::features::kCrostiniEnableDlc)},
+ {"guest-os-external-protocol",
+ flag_descriptions::kGuestOsExternalProtocolName,
+ flag_descriptions::kGuestOsExternalProtocolDescription, kOsCrOS,
+ FEATURE_VALUE_TYPE(chromeos::features::kGuestOsExternalProtocol)},
{"pluginvm-show-camera-permissions",
flag_descriptions::kPluginVmShowCameraPermissionsName,
flag_descriptions::kPluginVmShowCameraPermissionsDescription, kOsCrOS,
