Use StringPiece for CreateUploader/NetMetricsLogUploader params.
Makes MetricsLogUploader a pure interface, eliminating the params there, and
in TestMetricsLogUploader.
TBR=boliu,olivierrobin
BUG=693676
Review-Url: https://codereview.chromium.org/2735443003
Cr-Commit-Position: refs/heads/master@{#455308}
diff --git a/components/metrics/test_metrics_service_client.cc b/components/metrics/test_metrics_service_client.cc
index b68bef8..965cfb1 100644
--- a/components/metrics/test_metrics_service_client.cc
+++ b/components/metrics/test_metrics_service_client.cc
@@ -65,12 +65,11 @@
}
std::unique_ptr<MetricsLogUploader> TestMetricsServiceClient::CreateUploader(
- const std::string& server_url,
- const std::string& mime_type,
+ base::StringPiece server_url,
+ base::StringPiece mime_type,
MetricsLogUploader::MetricServiceType service_type,
const base::Callback<void(int)>& on_upload_complete) {
- uploader_ = new TestMetricsLogUploader(server_url, mime_type, service_type,
- on_upload_complete);
+ uploader_ = new TestMetricsLogUploader(on_upload_complete);
return std::unique_ptr<MetricsLogUploader>(uploader_);
}
