| commit | 4daa5122518cd0550746f3f637635f4285695d5f | [log] [tgz] |
|---|---|---|
| author | Daniel Cheng <[email protected]> | Sun Feb 21 07:20:11 2021 |
| committer | Chromium LUCI CQ <[email protected]> | Sun Feb 21 07:20:11 2021 |
| tree | 70b2a51ab37520f05f9bdeb6211c1172ba8ffbc0 | |
| parent | cfeb023c9506290e51ea4bd64c78823ef1dc615d [diff] |
Use strongly-typed frame tokens when creating a new RenderView.
- CreateFrameCommonParams no longer makes sense: the frame token has
migrated into local-specific or remote-specific params. That leaves
only the devtools token (which there is a desire to eliminate) and
the frame replication state. Rather than have a struct with so few
fields, just roll them back up.
- Rearranges and standardizes the naming of several common fields:
- frame_token -> token to mirror the naming of routing_id, when
already embedded in a frame context.
- moving frame_token adjacent to routing_id, since they serve similar
purposes
- renaming replicated_state to replication_state to be consistent
- Migrates a few frame token parameters from the generic
base::UnguessableToken type to a strongly-typed frame token for
consistency.
Change-Id: Idb3d8f7b7b3d32d9c1dd30634a1032b223c6aee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2708303
Commit-Queue: Daniel Cheng <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Aaron Colwell <[email protected]>
Reviewed-by: Chris Hamilton <[email protected]>
Cr-Commit-Position: refs/heads/master@{#856134}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.