Make gypv8sh.py compatible with ninja on Windows.
This is because python's subprocess.py excepts GetStdHandle(STD_INPUT_HANDLE) to return a valid handle and it seems ninja on Windows doesn't give one, causing the subprocess.call() to fail unless we request stdin to be redirected.
Also fix file handle lifetime in gypv8sh.py
When an exception is thrown, the file handle could still be open, causing an
exception while trying to remove it in the exception handler due to file locking
on Windows.
Note that the exception being generated is another problem but this exception in
the exception handler was masking the original error.
[email protected]
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10388191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137902 0039d316-1c4b-4281-b951-d872f2087c98
1 file changed