Google Git
Sign in
chromium / chromium / src.git / 5243a7ec7958c311012e6a03b688f39524d4d73f
commit5243a7ec7958c311012e6a03b688f39524d4d73f[log] [tgz]
authorPeter Kasting <[email protected]>Tue Nov 27 17:11:53 2018
committerCommit Bot <[email protected]>Tue Nov 27 17:11:53 2018
tree0cf02d3c2b64c9f21e63d110844925caa6b7ea36
parentba54c0e292a9f2069c8a5e63e16849eecd5ada53 [diff]
Use root window coords in EventGenerator constructor, screen coords elsewhere.

This feels inconsistent to me, but seems to be the best match for existing
practice and API documentation.  The other choice would be to use screen coords
everywhere, but this will require fixing up more tests.

This is a necessary precursor to using the configured screen position client by
default; right now, root window and screen coords are equivalent, so being
inconsistent about this doesn't matter.

One side effect here is that when constructed with a root window but no specific
starting point, the event generator's initial position will now be the origin of
the root window instead of the origin of the screen.

Bug: none
Change-Id: I9b9138a2fbd44ddf5c585f04db9927c4f052eb00
Reviewed-on: https://chromium-review.googlesource.com/c/1347587
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/master@{#611154}
40 files changed
tree: 0cf02d3c2b64c9f21e63d110844925caa6b7ea36
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .