| commit | b7661721d3ae6085748873a7495d87af3cbe0825 | [log] [tgz] |
|---|---|---|
| author | Kenichi Ishibashi <[email protected]> | Tue Apr 03 07:02:24 2018 |
| committer | Commit Bot <[email protected]> | Tue Apr 03 07:02:24 2018 |
| tree | 523c5abf967569a6635dc9a2d9bc11af7409c1d1 | |
| parent | a5bb8be761864163f49b470e0436c7e4cc5a0a7d [diff] |
S13nSW: GetControllerServiceWorkerPtr() doesn't ensure the controller is running The method is similar to EnsureControllerServiceWorker but in some cases we can't make sure that the controller service worker is running (as existing comment described). Update the description of the method to state that this method doesn't guarantee that the controller is running. The method will be called during navigation when S13nSW is enabled. During navigation, we need to make sure that the controller is running before calling this method. Currently we make sure this by calling ServiceWorkerFetchDispatcher::StartWorker() in the following sequence: ServiceWorkerControlleeRequestHandler::MaybeCreateLoader() -> ServiceWorkerURLJobWrapper::ForwardToServiceWorker() -> ServiceWorkerNavigationLoader::ForwardToServiceWorker() -> ServiceWorkerFetchDispatcher::Run() -> ServiceWorkerFetchDispatcher::StartWorker() After creating a loader, we call GetControllerServiceWorkerPtr() in ServiceWorkerControlleeReuqestHandler::MaybeCreateSubresourceLoaderParams(). Bug: 797222 Change-Id: If7ef6dbe2e59c15e2f737f16d68f0c851d889556 Reviewed-on: https://chromium-review.googlesource.com/987832 Reviewed-by: Kinuko Yasuda <[email protected]> Reviewed-by: Matt Falkenhagen <[email protected]> Commit-Queue: Kenichi Ishibashi <[email protected]> Cr-Commit-Position: refs/heads/master@{#547634}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .