Google Git
Sign in
chromium / chromium / src.git / 53131349c4aba96c9c9fe79319aaf44705a9f9c6
commit53131349c4aba96c9c9fe79319aaf44705a9f9c6[log] [tgz]
authorMikel Astiz <[email protected]>Thu Jul 19 08:59:58 2018
committerCommit Bot <[email protected]>Thu Jul 19 08:59:58 2018
treebaefd4244b1d9c05e7fbd3e3206560fa0c42fb0c
parentcd0d9861ee13bec2f79b6be872f8e7aa3ab759f8 [diff]
Get rid of home-grown singleton maps for ModelTypeStore

Prior to this patch, ModelTypeStoreImpl and ModelTypeStoreBackend
internally maintain singleton maps to achieve what KeyedServices are
designed for: have single instances of certain objects per profile. The
implementation was rather error-prone (e.g. to leak data across
profiles) and the object lifetime questionable.

Instead, this patch replaces them with a newly introduced keyed service,
ModelTypeStoreService, which is designed to abstract away sync's needs
to persist data. The associated semantics wrt lifetime, incognito
etc. are more standard now.

For directory, we don't migrate the code other than making the keyed
service the authoritative source for defining where data should be
persisted (FS path). We do this to minimize the diff, and because we
expect all datatypes to be eventually migrated to USS in the long term.

Bug: 862942
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib444220ead181b6765c863703439eec18fcb0886
Reviewed-on: https://chromium-review.googlesource.com/1134774
Reviewed-by: Colin Blundell <[email protected]>
Reviewed-by: Eric Noyau <[email protected]>
Reviewed-by: Bernhard Bauer <[email protected]>
Reviewed-by: Markus Heintz <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Reviewed-by: Sean Kau <[email protected]>
Commit-Queue: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#576424}
53 files changed
tree: baefd4244b1d9c05e7fbd3e3206560fa0c42fb0c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .