Google Git
Sign in
chromium / chromium / src.git / 5361171354216b62e9902d8b95e49505b691796f
commit5361171354216b62e9902d8b95e49505b691796f[log] [tgz]
authorkylechar <[email protected]>Fri Apr 26 18:23:12 2019
committerCommit Bot <[email protected]>Fri Apr 26 18:23:12 2019
treeab67573683302d130646a60163ee92848f714c48
parent9d4080e648e9f61e3f53f5738bf5014c52cf16d1 [diff]
Add mojo interface for vsync parameter updates.

Exo observes vsync parameter changes for the primary display and sends
updates over the wayland protocol to arc++. This allows arc++ to produce
frames at the correct rate and time. Currently exo adds an observer to
CompositorVsyncManager. This works because vsync parameter updates are
forwarded back from the GPU process to ui::Compositor without OOP-D.

With OOP-D enabled the BeginFrameSource is moved into the GPU process.
ui::Compositor is no longer involved in setting vsync parameters and
CompositorVsyncManager no longer works.

Add a new mojo interface that exo can subscribe to vsync parameter
updates on. Move the logic to throttle sending vsync parameter updates
out of exo and into the sending end of the mojo interface. This will
limit the number of IPC messages. The throttling is improved slightly by
handing modulus roll over when the timebase is near a multiple of the
interval.

The mojom::VSyncParameterObserver interface is implemented both with and
without OOP-D. This removes the last usage of CompositorVsyncManager so
we can delete it.

Bug: 949711, 441577
Change-Id: I966b2d9dcc660efbdfb1c2800c71b6de3024e186
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554834
Reviewed-by: Daniele Castagna <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Luke Halliwell <[email protected]>
Commit-Queue: kylechar <[email protected]>
Cr-Commit-Position: refs/heads/master@{#654530}
37 files changed
tree: ab67573683302d130646a60163ee92848f714c48
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .