Google Git
Sign in
chromium / chromium / src.git / 536f57c0fd998ebb788a668544e721fa87d0fd74
commit536f57c0fd998ebb788a668544e721fa87d0fd74[log] [tgz]
authorBen Pastene <[email protected]>Mon May 17 23:21:56 2021
committerChromium LUCI CQ <[email protected]>Mon May 17 23:21:56 2021
treec68af86c2b9fe060f1f6486027091dacd4532cc3
parentba0bbabefa481296e11432b5f5e79a7dcfa3583c [diff]
Disable intercept_tls_get_addr for LSan tests on linux.

https://github.com/google/sanitizers/issues/1322

According to that github issue, lsan will mistakenly detect "2.19 for
the real glibc of version 2.25 or higher."

On our xenial test bots, /lib/x86_64-linux-gnu/libc.so.6 is 2.23. On
our bionic test bots, libc is 2.27. So when we switched our asan/lsan
tests to bionic, we started hitting strange lsan errors:

Tracer caught signal 11: addr=0x330004f3 pc=0x55af5266644a sp=0x7f405e956d40
==28674==LeakSanitizer has encountered a fatal error.
eg: https://chromium-swarm.appspot.com/task?id=53745e69a9525810

It appears that error is the same reported in the github issue, as
disabling the DTLS check prevents those same LSan errors.

Though this doesn't entirely explain why the failures are transient
when nothing about the bots seemingly changes. eg:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20%281%29
Why does components_unittests fail in builds 89913 - 89916, but is
fine before and after?

Bug: 1200574
Change-Id: Id8ffed3bd50d648a1147de50bb4fd2f001c01d12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2888418
Reviewed-by: Thomas Anderson <[email protected]>
Reviewed-by: Garrett Beaty <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
Owners-Override: Garrett Beaty <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/heads/master@{#883698}
1 file changed
tree: c68af86c2b9fe060f1f6486027091dacd4532cc3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.