| commit | 54ad0480e005dbf38a161e60ccbe6bb972144065 | [log] [tgz] |
|---|---|---|
| author | Gyuyoung Kim <[email protected]> | Tue Feb 12 02:06:50 2019 |
| committer | Commit Bot <[email protected]> | Tue Feb 12 02:06:50 2019 |
| tree | a43a66b6d7a8f04050dd9f79bb4c939171c075a3 | |
| parent | b6a69427be33da517edbcc0500d3c61e33e4fcd3 [diff] [blame] |
s13n: Rename IdentityManager::Observer::OnAccountRemovedWithInfo This method will be invoked just before the extended information about an account is removed. It would be good to be renamed to reflect that the extended information is still available and is passed to the method. Bug: 930122 Change-Id: I95c0a837e42c056288d777ba8bf3c916133b2a52 Reviewed-on: https://chromium-review.googlesource.com/c/1460745 Reviewed-by: Gyuyoung Kim <[email protected]> Reviewed-by: Sylvain Defresne <[email protected]> Reviewed-by: Scott Violet <[email protected]> Commit-Queue: Gyuyoung Kim <[email protected]> Cr-Commit-Position: refs/heads/master@{#631041}
diff --git a/chrome/browser/extensions/api/identity/identity_api.h b/chrome/browser/extensions/api/identity/identity_api.h index 6f7f860..057a33f3 100644 --- a/chrome/browser/extensions/api/identity/identity_api.h +++ b/chrome/browser/extensions/api/identity/identity_api.h
@@ -134,7 +134,7 @@ // NOTE: This class must listen for this callback rather than // OnRefreshTokenRemovedForAccount() to obtain the Gaia ID of the removed // account. - void OnAccountRemovedWithInfo(const AccountInfo& info) override; + void OnExtendedAccountInfoRemoved(const AccountInfo& info) override; // Fires the chrome.identity.onSignInChanged event. void FireOnAccountSignInChanged(const std::string& gaia_id,