Pass validated URL to WebContentsObserver::DidFailProvidsionalLoad
We used to filter URL in DidFailProvisionalLoadWithError in WebContentsImpl
before r243208 and used to pass the filtered/validated url to
WCO::DidFailProvisionalLoad. Moving filtering to NavigatorImpl caused this
to change, this CL restores the behavior.
BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2151743002
Cr-Commit-Position: refs/heads/master@{#405556}
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 8facc1c..a9bb2ae 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -3225,15 +3225,14 @@
void WebContentsImpl::DidFailProvisionalLoadWithError(
RenderFrameHostImpl* render_frame_host,
- const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params) {
- GURL validated_url(params.url);
- FOR_EACH_OBSERVER(WebContentsObserver,
- observers_,
- DidFailProvisionalLoad(render_frame_host,
- validated_url,
- params.error_code,
- params.error_description,
- params.was_ignored_by_handler));
+ const GURL& validated_url,
+ int error_code,
+ const base::string16& error_description,
+ bool was_ignored_by_handler) {
+ FOR_EACH_OBSERVER(
+ WebContentsObserver, observers_,
+ DidFailProvisionalLoad(render_frame_host, validated_url, error_code,
+ error_description, was_ignored_by_handler));
FrameTreeNode* ftn = render_frame_host->frame_tree_node();
BrowserAccessibilityManager* manager =
