Google Git
Sign in
chromium / chromium / src.git / 58ae65c7f9a276777e611db69633b2ff8ed32cb7
commit58ae65c7f9a276777e611db69633b2ff8ed32cb7[log] [tgz]
authorCollin Baker <[email protected]>Fri Feb 05 21:12:29 2021
committerChromium LUCI CQ <[email protected]>Fri Feb 05 21:12:29 2021
tree9268536cd69a827b7b4519a30fc360d23709fffd
parent3ea41be7660e5917548b1522aab0f8fedb64574f [diff]
Make "open all bookmarks" safe

chrome::OpenAll may prompt the user before opening many bookmarks. It
uses a nested RunLoop to do so. However, it takes as arguments
pointers that may be invalid at the end of this RunLoop.

This CL replaces chrome::OpenAll with chrome::OpenAllIfAllowed, which
returns immediately and opens the tabs asynchronously if prompting the
user. Instead of taking a content::PageNavigator pointer directly, it
takes a callback to fetch the pointer after the user acknowledges the
prompt. This can ensure a valid PageNavigator is used.

Another function chrome::OpenAllImmediately is added for tests which
shouldn't open a message box.

Fixed: 1161144
Change-Id: I6d0d73ec1d9deaf3cb339dc9646d7fe77a27674e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2650689
Commit-Queue: Collin Baker <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Auto-Submit: Collin Baker <[email protected]>
Cr-Commit-Position: refs/heads/master@{#851279}
22 files changed
tree: 9268536cd69a827b7b4519a30fc360d23709fffd
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.