Return SyncService* from ProfileSyncServiceFactory::GetForProfile
Generally, SyncService (the interface) should be preferred over
ProfileSyncService (the implementation). This CL changes the "main"
GetForProfile method on ProfileSyncService to only return a SyncService*
(instead of ProfileSyncService*), and trivially updates a few call sites
to refer to SyncService*.
It also add a new GetAsProfileSyncServiceForProfile as an escape hatch
for the few places (mostly tests) that do still need a
ProfileSyncService*.
Bug: 924508
Change-Id: Id99a70515b9cf614550bce35b8f05bf4b58eccc6
Reviewed-on: https://chromium-review.googlesource.com/c/1477014
Commit-Queue: Marc Treib <[email protected]>
Reviewed-by: Mikel Astiz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#633285}diff --git a/chrome/browser/extensions/extension_service_sync_unittest.cc b/chrome/browser/extensions/extension_service_sync_unittest.cc
index c03afb43..20b7147 100644
--- a/chrome/browser/extensions/extension_service_sync_unittest.cc
+++ b/chrome/browser/extensions/extension_service_sync_unittest.cc
@@ -344,7 +344,7 @@
InitializeInstalledExtensionService(pref_path, source_install_dir);
// The user has enabled sync.
- browser_sync::ProfileSyncService* sync_service =
+ syncer::SyncService* sync_service =
ProfileSyncServiceFactory::GetForProfile(profile());
sync_service->GetUserSettings()->SetFirstSetupComplete();
@@ -380,7 +380,7 @@
InitializeEmptyExtensionService();
// Enable sync.
- browser_sync::ProfileSyncService* sync_service =
+ syncer::SyncService* sync_service =
ProfileSyncServiceFactory::GetForProfile(profile());
sync_service->GetUserSettings()->SetFirstSetupComplete();
@@ -462,7 +462,7 @@
InitializeEmptyExtensionService();
// Enable sync.
- browser_sync::ProfileSyncService* sync_service =
+ syncer::SyncService* sync_service =
ProfileSyncServiceFactory::GetForProfile(profile());
sync_service->GetUserSettings()->SetFirstSetupComplete();
@@ -528,7 +528,7 @@
InitializeInstalledExtensionService(pref_path, source_install_dir);
// The user has enabled sync.
- browser_sync::ProfileSyncService* sync_service =
+ syncer::SyncService* sync_service =
ProfileSyncServiceFactory::GetForProfile(profile());
sync_service->GetUserSettings()->SetFirstSetupComplete();
// Make sure ExtensionSyncService is created, so it'll be notified of changes.
@@ -2631,7 +2631,7 @@
InitializeEmptyExtensionService();
// Enable sync.
- browser_sync::ProfileSyncService* sync_service =
+ syncer::SyncService* sync_service =
ProfileSyncServiceFactory::GetForProfile(profile());
sync_service->GetUserSettings()->SetFirstSetupComplete();
