Google Git
Sign in
chromium / chromium / src.git / 5bc0d15611101cdd35c24f687e52cd040e4f934a
commit5bc0d15611101cdd35c24f687e52cd040e4f934a[log] [tgz]
authorAnton Bikineev <[email protected]>Thu May 13 03:56:02 2021
committerChromium LUCI CQ <[email protected]>Thu May 13 03:56:02 2021
tree8c26a3c51d5b7aecf768c891523b22d89ed1cf24
parentf153c9cfc9f555239bd5b01644e3c74b0345f6ee [diff]
Fix missing dependencies on //base

Components that depend on //base must have this dep explicitly specified
in GN. Components that include things from base in public headers must
specify //base as a public dep. Otherwise, this can lead to subtle ODR
violation issues (for example, when a component transitively includes
something from base but some configuration macro is not defined due to
a missing dep in the intermediate component).

This is a prerequisite for the LSC that replaces base::Optional with
absl::optional.

Bug: 1202909
Change-Id: I19846008f3c6c3487f63a0f6811916e040810823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2891566
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Owners-Override: Kentaro Hara <[email protected]>
Owners-Override: Peter Kasting <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/heads/master@{#882447}
29 files changed
tree: 8c26a3c51d5b7aecf768c891523b22d89ed1cf24
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.