Try one more time to check in http://codereview.chromium.org/60112
Added this test to the list of skipped purify tests as it is
experience the same issue as ExtensionView test.
I also found an unrelated memory leak and created a patch
separately: http://codereview.chromium.org/63073
Review URL: http://codereview.chromium.org/63075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13369 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/chrome/browser/extensions/extension.h b/chrome/browser/extensions/extension.h
index 5c3d9b8f..2f59115 100644
--- a/chrome/browser/extensions/extension.h
+++ b/chrome/browser/extensions/extension.h
@@ -100,7 +100,10 @@
}
// Initialize the extension from a parsed manifest.
- bool InitFromValue(const DictionaryValue& value, std::string* error);
+ // If |require_id| is true, will return an error if the "id" key is missing
+ // from the value.
+ bool InitFromValue(const DictionaryValue& value, bool require_id,
+ std::string* error);
// Returns an absolute path to a resource inside of an extension if the
// extension has a theme defined with the given |resource_id|. Otherwise
@@ -110,9 +113,8 @@
FilePath GetThemeResourcePath(const int resource_id);
const FilePath& path() const { return path_; }
- const GURL& url();
+ const GURL& url() const { return extension_url_; }
const std::string& id() const { return id_; }
- void set_id(const std::string& id);
const Version* version() const { return version_.get(); }
// String representation of the version number.
const std::string VersionString() const;
