Eliminate ScopedCustomUrlRequestTestHttpHost.
I wasted some time trying to figure out what this was (it's nothing,
apparently, anymore), so I decided to clean it up to prevent that
from happening to somebody else.
BUG=334634
Review URL: https://codereview.chromium.org/1114353003
Cr-Commit-Position: refs/heads/master@{#328176}
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index ded1f5cc..77438c2 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -2134,22 +2134,23 @@
// TODO(droger): Support SpawnedTestServer on iOS (see http://crbug.com/148666).
#if !defined(OS_IOS)
-// A subclass of SpawnedTestServer that uses a statically-configured hostname.
-// This is to work around mysterious failures in chrome_frame_net_tests. See:
-// http://crbug.com/114369
-// TODO(erikwright): remove or update as needed; see http://crbug.com/334634.
+namespace {
+
+// Less verbose way of running a simple testserver for the tests below.
class LocalHttpTestServer : public SpawnedTestServer {
public:
explicit LocalHttpTestServer(const base::FilePath& document_root)
: SpawnedTestServer(SpawnedTestServer::TYPE_HTTP,
- ScopedCustomUrlRequestTestHttpHost::value(),
+ SpawnedTestServer::kLocalhost,
document_root) {}
LocalHttpTestServer()
: SpawnedTestServer(SpawnedTestServer::TYPE_HTTP,
- ScopedCustomUrlRequestTestHttpHost::value(),
+ SpawnedTestServer::kLocalhost,
base::FilePath()) {}
};
+} // namespace
+
TEST_F(URLRequestTest, DelayedCookieCallback) {
LocalHttpTestServer test_server;
ASSERT_TRUE(test_server.Start());
