Origin identifiers are always ASCII, store as std::string
Origin identifiers are computed by a process that always produces ASCII strings.
There's no reason to store origin identifiers as base::string16 or to do
unicode conversions for them. Keeping them stored in std::string is a slight memory
and performance improvement and avoids lots of sketchy conversions when converting
to FilePaths.
This patch still involves a number of conversions (or things that look like conversions)
at the WebKit API boundary.
BUG=243095
Review URL: https://chromiumcodereview.appspot.com/16965018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206903 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/content/common/database_messages.h b/content/common/database_messages.h
index 73a2cc6c..2a20947 100644
--- a/content/common/database_messages.h
+++ b/content/common/database_messages.h
@@ -14,22 +14,22 @@
// Notifies the child process of the new database size
IPC_MESSAGE_CONTROL3(DatabaseMsg_UpdateSize,
- string16 /* the origin */,
+ std::string /* the origin */,
string16 /* the database name */,
int64 /* the new database size */)
// Notifies the child process of the new space available
IPC_MESSAGE_CONTROL2(DatabaseMsg_UpdateSpaceAvailable,
- string16 /* the origin */,
+ std::string /* the origin */,
int64 /* space available to origin */)
// Notifies the child process to reset it's cached value for the origin.
IPC_MESSAGE_CONTROL1(DatabaseMsg_ResetSpaceAvailable,
- string16 /* the origin */)
+ std::string /* the origin */)
// Asks the child process to close a database immediately
IPC_MESSAGE_CONTROL2(DatabaseMsg_CloseImmediately,
- string16 /* the origin */,
+ std::string /* the origin */,
string16 /* the database name */)
// Database messages sent from the renderer to the browser.
@@ -58,28 +58,28 @@
// Asks the browser process for the amount of space available to an origin
IPC_SYNC_MESSAGE_CONTROL1_1(DatabaseHostMsg_GetSpaceAvailable,
- string16 /* origin identifier */,
+ std::string /* origin identifier */,
int64 /* remaining space available */)
// Notifies the browser process that a new database has been opened
IPC_MESSAGE_CONTROL4(DatabaseHostMsg_Opened,
- string16 /* origin identifier */,
+ std::string /* origin identifier */,
string16 /* database name */,
string16 /* database description */,
int64 /* estimated size */)
// Notifies the browser process that a database might have been modified
IPC_MESSAGE_CONTROL2(DatabaseHostMsg_Modified,
- string16 /* origin identifier */,
+ std::string /* origin identifier */,
string16 /* database name */)
// Notifies the browser process that a database is about to close
IPC_MESSAGE_CONTROL2(DatabaseHostMsg_Closed,
- string16 /* origin identifier */,
+ std::string /* origin identifier */,
string16 /* database name */)
// Sent when a sqlite error indicates the database is corrupt.
IPC_MESSAGE_CONTROL3(DatabaseHostMsg_HandleSqliteError,
- string16 /* origin identifier */,
+ std::string /* origin identifier */,
string16 /* database name */,
int /* error */)
