Currently Underline Position is not calculated from Font Metrics, by
default Blink makes 1-pixel gap between baseline and underline
position. This patch adds support for to obtain Underline position
from Font Metrics
Skia patch is in review process for Underline Thickness and Position, added comments to Skia related Blink files which needs to update once Skia patch is committed.
BUG=347510
Review URL: https://codereview.chromium.org/182923003
git-svn-id: svn://svn.chromium.org/blink/trunk@171050 bbb929c8-8fbe-4397-9dbb-9b2b20218538
diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations
index ee42970a..a5da19ce 100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -1084,3 +1084,57 @@
crbug.com/320139 virtual/softwarecompositing/repaint/resize-repaint.html [ NeedsRebaseline ]
crbug.com/320139 [ Mac ] css3/flexbox/repaint.html [ NeedsRebaseline ]
+# Way to Underline position code changed, need to rebase files after https://codereview.chromium.org/182923003/ .
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/pasteboard/paste-line-endings-002.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/text/international/rtl-white-space-pre-wrap.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/pasteboard/paste-4038267-fix.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/pasteboard/paste-line-endings-008.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/repaint/shadow-multiple-strict-vertical.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/block/float/centered-float-avoidance-complexity.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] http/tests/misc/acid2.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] ietestcenter/css3/text/textshadow-002.htm [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/text/line-breaks.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/pasteboard/paste-text-019.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/pasteboard/paste-line-endings-001.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/block/float/float-in-float-painting.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/pasteboard/paste-line-endings-003.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/pasteboard/paste-line-endings-007.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/style/block-styles-007.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] tables/mozilla/bugs/bug128229.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/block/positioning/auto/vertical-rl/007.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/repaint/shadow-multiple-strict-horizontal.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/pasteboard/paste-line-endings-004.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/pasteboard/paste-line-endings-006.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/inserting/return-key-with-selection-002.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/block/positioning/auto/007.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] svg/custom/svg-fonts-without-missing-glyph.xhtml [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/block/positioning/auto/vertical-lr/007.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/text/stroking-decorations.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/inserting/insert-div-023.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/style/style-3998892-fix.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/inserting/return-key-with-selection-003.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/repaint/shadow-multiple-horizontal.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/pasteboard/paste-match-style-002.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/css/acid2.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/block/float/float-in-float-hit-testing.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/css/clip-zooming.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/pasteboard/paste-line-endings-010.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/text/trailing-white-space.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/inserting/insert-div-022.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/pasteboard/paste-line-endings-005.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/pasteboard/paste-line-endings-009.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/css3-text/css3-text-decoration/text-decoration-style.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/style/smoosh-styles-003.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/text/decorations-with-text-combine.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/css/line-thickness-underline-strikethrough-overline.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/dom/clone-node-dynamic-style.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/repaint/shadow-multiple-vertical.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/text/trailing-white-space-2.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/css/first-line-text-decoration-inherited-from-parent.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] fast/css/first-line-text-decoration.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/inserting/return-key-with-selection-001.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/inserting/insert-div-024.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/inserting/insert-div-026.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ] editing/deleting/delete-4083333-fix.html [ NeedsRebaseline ]
+
