Canvas 2d: ignore RuntimeEnabledFeatures for LowLatency() cases
ToT looks at RuntimeEnabledFeatures::Canvas2dImageChromiumEnabled()
(enabled by default for Mac, disabled by default elsewhere) to use
ImageCHROMIUM for Canvas 2D contexts or not. This is fine, but in
the LowLatency it doesn't make sense not use that features, we
always want to use ImageCHROMIUM (if we |want_acceleration| at all).
Hence this CL:
- ignores the RuntimeEnabledFeature if LowLatency (so all platforms
will use ImageCHROMIUM for LowLatency -- if |want_acceleration|).
- removes the associated code in runtime_features.cc and about_flags.cc,
essentially undoing my previous crrev.com/c/1056168. (So that Mac
can still control the use of ImageCHROMIUM for non-low-latency cases).
Bonus cleanup: simplify |enable_web_gl_image_chromium| initialization.
Bug: 878405
Change-Id: I91c5422fad82b1146af02c193546f924bbe5448b
Reviewed-on: https://chromium-review.googlesource.com/1194473
Commit-Queue: Miguel Casas <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Fernando Serboncini <[email protected]>
Reviewed-by: ccameron <[email protected]>
Cr-Commit-Position: refs/heads/master@{#587930}diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 60493cef..a3f7ced 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1333,7 +1333,7 @@
SINGLE_VALUE_TYPE(switches::kIgnoreGpuBlacklist)},
{"enable-canvas-2d-image-chromium",
flag_descriptions::kCanvas2DImageChromiumName,
- flag_descriptions::kCanvas2DImageChromiumDescription, kOsMac | kOsCrOS,
+ flag_descriptions::kCanvas2DImageChromiumDescription, kOsMac,
FEATURE_VALUE_TYPE(features::kCanvas2DImageChromium)},
{"disable-accelerated-2d-canvas",
flag_descriptions::kAccelerated2dCanvasName,
