| commit | 6196698b3a0e79c34b40c99fe81eecb963d87537 | [log] [tgz] |
|---|---|---|
| author | David Tseng <[email protected]> | Wed Sep 15 03:11:31 2021 |
| committer | Chromium LUCI CQ <[email protected]> | Wed Sep 15 03:11:31 2021 |
| tree | f97da4951a51329cb7a3350b07742ec57ed82da4 | |
| parent | 91165bcef19e84b23e506b8ba28344e3be16e150 [diff] [blame] |
Fix ui/accessibility/PRESUBMIT.py
The presubmit loop breaks out prematurely when building the list of enum
values e.g.:
enum Foo {
bar = 0,
// breaks out here!
baz = 1
};
Corrected by continuing to process even when encountering non-enum value
lines e.g. comments.
[email protected], [email protected]
Fixed: 1249522
Change-Id: Ib3b62d157fab20e9c8cd5767a07f24be246ca10a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3160413
Commit-Queue: David Tseng <[email protected]>
Reviewed-by: Aaron Leventhal <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#921515}
diff --git a/ui/accessibility/PRESUBMIT.py b/ui/accessibility/PRESUBMIT.py index 95c7c25..1b47f31 100644 --- a/ui/accessibility/PRESUBMIT.py +++ b/ui/accessibility/PRESUBMIT.py
@@ -191,7 +191,7 @@ for enum_value in ax_enums[enum_name]: m = re.search("([\w]+) = ([\d]+)", enum_value) if not m: - break + continue enums_with_ordinal_values.setdefault(enum_name, []) enums_with_ordinal_values[enum_name].append(m.groups(1))