net: Remove unused NetLog parameter from FileStream's ctor
Remove NetLog parameter from FileStream's ctor to which all users are passing NULL.
Remove BoundNetLog from FileStream which does nothing if net_log==NULL.
Remove an enum (FileErrorSource), methods (RecordError, BeginOpenEvent, ProcessOpenError, ProcessAsyncResult, OnAsyncCompleted) and member variables (bound_net_log_ and error_source_) from file_stream_context.h.
BUG=361496
TEST=git cl try
Review URL: https://codereview.chromium.org/242873003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265576 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/net/base/file_stream_unittest.cc b/net/base/file_stream_unittest.cc
index 5a8c279..75379e8 100644
--- a/net/base/file_stream_unittest.cc
+++ b/net/base/file_stream_unittest.cc
@@ -68,7 +68,7 @@
TEST_F(FileStreamTest, AsyncOpenExplicitClose) {
TestCompletionCallback callback;
- FileStream stream(NULL);
+ FileStream stream;
int flags = base::File::FLAG_OPEN |
base::File::FLAG_READ |
base::File::FLAG_ASYNC;
@@ -86,7 +86,7 @@
TEST_F(FileStreamTest, AsyncOpenExplicitCloseOrphaned) {
TestCompletionCallback callback;
scoped_ptr<FileStream> stream(new FileStream(
- NULL, base::MessageLoopProxy::current()));
+ base::MessageLoopProxy::current()));
int flags = base::File::FLAG_OPEN | base::File::FLAG_READ |
base::File::FLAG_ASYNC;
int rv = stream->Open(temp_file_path(), flags, callback.callback());
@@ -116,7 +116,7 @@
// Seek to the beginning of the file and read.
scoped_ptr<FileStream> read_stream(
- new FileStream(file.Pass(), NULL, base::MessageLoopProxy::current()));
+ new FileStream(file.Pass(), base::MessageLoopProxy::current()));
ASSERT_EQ(ERR_IO_PENDING,
read_stream->Seek(FROM_BEGIN, 0, callback64.callback()));
ASSERT_EQ(0, callback64.WaitForResult());
@@ -135,7 +135,7 @@
file.Initialize(temp_file_path(), flags);
scoped_ptr<FileStream> write_stream(
- new FileStream(file.Pass(), NULL, base::MessageLoopProxy::current()));
+ new FileStream(file.Pass(), base::MessageLoopProxy::current()));
ASSERT_EQ(ERR_IO_PENDING,
write_stream->Seek(FROM_BEGIN, 0, callback64.callback()));
ASSERT_EQ(0, callback64.WaitForResult());
@@ -157,7 +157,7 @@
TestCompletionCallback callback;
TestInt64CompletionCallback callback64;
- FileStream stream(NULL, base::MessageLoopProxy::current());
+ FileStream stream(base::MessageLoopProxy::current());
EXPECT_FALSE(stream.IsOpen());
@@ -175,7 +175,7 @@
int64 file_size;
EXPECT_TRUE(base::GetFileSize(temp_file_path(), &file_size));
- FileStream stream(NULL, base::MessageLoopProxy::current());
+ FileStream stream(base::MessageLoopProxy::current());
int flags = base::File::FLAG_OPEN | base::File::FLAG_READ |
base::File::FLAG_ASYNC;
TestCompletionCallback callback;
@@ -206,7 +206,7 @@
EXPECT_TRUE(base::GetFileSize(temp_file_path(), &file_size));
scoped_ptr<FileStream> stream(
- new FileStream(NULL, base::MessageLoopProxy::current()));
+ new FileStream(base::MessageLoopProxy::current()));
int flags = base::File::FLAG_OPEN | base::File::FLAG_READ |
base::File::FLAG_ASYNC;
TestCompletionCallback callback;
@@ -231,7 +231,7 @@
int64 file_size;
EXPECT_TRUE(base::GetFileSize(temp_file_path(), &file_size));
- FileStream stream(NULL, base::MessageLoopProxy::current());
+ FileStream stream(base::MessageLoopProxy::current());
int flags = base::File::FLAG_OPEN | base::File::FLAG_READ |
base::File::FLAG_ASYNC;
TestCompletionCallback callback;
@@ -265,7 +265,7 @@
}
TEST_F(FileStreamTest, AsyncSeekAround) {
- FileStream stream(NULL, base::MessageLoopProxy::current());
+ FileStream stream(base::MessageLoopProxy::current());
int flags = base::File::FLAG_OPEN | base::File::FLAG_ASYNC |
base::File::FLAG_READ;
TestCompletionCallback callback;
@@ -300,7 +300,7 @@
}
TEST_F(FileStreamTest, AsyncWrite) {
- FileStream stream(NULL, base::MessageLoopProxy::current());
+ FileStream stream(base::MessageLoopProxy::current());
int flags = base::File::FLAG_CREATE_ALWAYS | base::File::FLAG_WRITE |
base::File::FLAG_ASYNC;
TestCompletionCallback callback;
@@ -334,7 +334,7 @@
TEST_F(FileStreamTest, AsyncWrite_EarlyDelete) {
scoped_ptr<FileStream> stream(
- new FileStream(NULL, base::MessageLoopProxy::current()));
+ new FileStream(base::MessageLoopProxy::current()));
int flags = base::File::FLAG_CREATE_ALWAYS | base::File::FLAG_WRITE |
base::File::FLAG_ASYNC;
TestCompletionCallback callback;
@@ -364,7 +364,7 @@
int64 file_size;
EXPECT_TRUE(base::GetFileSize(temp_file_path(), &file_size));
- FileStream stream(NULL, base::MessageLoopProxy::current());
+ FileStream stream(base::MessageLoopProxy::current());
int flags = base::File::FLAG_OPEN | base::File::FLAG_WRITE |
base::File::FLAG_ASYNC;
TestCompletionCallback callback;
@@ -404,7 +404,7 @@
EXPECT_TRUE(base::GetFileSize(temp_file_path(), &file_size));
scoped_ptr<FileStream> stream(
- new FileStream(NULL, base::MessageLoopProxy::current()));
+ new FileStream(base::MessageLoopProxy::current()));
int flags = base::File::FLAG_OPEN | base::File::FLAG_READ |
base::File::FLAG_WRITE | base::File::FLAG_ASYNC;
TestCompletionCallback callback;
@@ -457,7 +457,7 @@
EXPECT_TRUE(base::GetFileSize(temp_file_path(), &file_size));
scoped_ptr<FileStream> stream(
- new FileStream(NULL, base::MessageLoopProxy::current()));
+ new FileStream(base::MessageLoopProxy::current()));
int flags = base::File::FLAG_OPEN | base::File::FLAG_READ |
base::File::FLAG_WRITE | base::File::FLAG_ASYNC;
TestCompletionCallback callback;
@@ -624,7 +624,7 @@
EXPECT_TRUE(base::GetFileSize(temp_file_path(), &file_size));
scoped_ptr<FileStream> stream(
- new FileStream(NULL, base::MessageLoopProxy::current()));
+ new FileStream(base::MessageLoopProxy::current()));
int flags = base::File::FLAG_OPEN | base::File::FLAG_READ |
base::File::FLAG_WRITE | base::File::FLAG_ASYNC;
TestCompletionCallback open_callback;
@@ -728,7 +728,7 @@
EXPECT_TRUE(base::GetFileSize(temp_file_path(), &file_size));
scoped_ptr<FileStream> stream(
- new FileStream(NULL, base::MessageLoopProxy::current()));
+ new FileStream(base::MessageLoopProxy::current()));
int flags = base::File::FLAG_OPEN | base::File::FLAG_READ |
base::File::FLAG_WRITE | base::File::FLAG_ASYNC;
TestCompletionCallback open_callback;
@@ -758,7 +758,7 @@
TEST_F(FileStreamTest, AsyncOpenAndDelete) {
scoped_ptr<FileStream> stream(
- new FileStream(NULL, base::MessageLoopProxy::current()));
+ new FileStream(base::MessageLoopProxy::current()));
int flags = base::File::FLAG_OPEN | base::File::FLAG_WRITE |
base::File::FLAG_ASYNC;
TestCompletionCallback open_callback;
@@ -783,7 +783,7 @@
ASSERT_TRUE(file.IsValid());
scoped_ptr<FileStream> stream(
- new FileStream(file.Pass(), NULL, base::MessageLoopProxy::current()));
+ new FileStream(file.Pass(), base::MessageLoopProxy::current()));
scoped_refptr<IOBuffer> buf = new IOBuffer(1);
buf->data()[0] = 0;
@@ -808,7 +808,7 @@
ASSERT_TRUE(file.IsValid());
scoped_ptr<FileStream> stream(
- new FileStream(file.Pass(), NULL, base::MessageLoopProxy::current()));
+ new FileStream(file.Pass(), base::MessageLoopProxy::current()));
scoped_refptr<IOBuffer> buf = new IOBuffer(1);
TestCompletionCallback callback;
@@ -840,7 +840,7 @@
EXPECT_TRUE(base::GetFileSize(path, &file_size));
EXPECT_LT(0, file_size);
- FileStream stream(NULL, base::MessageLoopProxy::current());
+ FileStream stream(base::MessageLoopProxy::current());
int flags = base::File::FLAG_OPEN | base::File::FLAG_READ |
base::File::FLAG_ASYNC;
TestCompletionCallback callback;
