Standardize usage of virtual/override/final specifiers.
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
[email protected]
Review URL: https://codereview.chromium.org/663043004
Cr-Commit-Position: refs/heads/master@{#301452}
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index 700b070..d900069d 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -615,7 +615,7 @@
default_context_.set_job_factory(&job_factory_);
default_context_.Init();
}
- virtual ~URLRequestTest() {
+ ~URLRequestTest() override {
// URLRequestJobs may post clean-up tasks on destruction.
base::RunLoop().RunUntilIdle();
}
@@ -6452,7 +6452,7 @@
default_context_.set_network_delegate(&default_network_delegate_);
default_context_.Init();
}
- virtual ~HTTPSRequestTest() {}
+ ~HTTPSRequestTest() override {}
protected:
TestNetworkDelegate default_network_delegate_; // Must outlive URLRequest.
@@ -7125,7 +7125,7 @@
class HTTPSFallbackTest : public testing::Test {
public:
HTTPSFallbackTest() : context_(true) {}
- virtual ~HTTPSFallbackTest() {}
+ ~HTTPSFallbackTest() override {}
protected:
void DoFallbackTest(const SpawnedTestServer::SSLOptions& ssl_options) {
@@ -7377,7 +7377,7 @@
default_context_.set_cert_verifier(&cert_verifier_);
default_context_.Init();
}
- virtual ~HTTPSSessionTest() {}
+ ~HTTPSSessionTest() override {}
protected:
MockCertVerifier cert_verifier_;
@@ -7476,7 +7476,7 @@
kOCSPTestCertPolicy)) {
}
- virtual void SetUp() override {
+ void SetUp() override {
SetupContext(&context_);
context_.Init();
@@ -7513,7 +7513,7 @@
*out_cert_status = r->ssl_info().cert_status;
}
- virtual ~HTTPSOCSPTest() {
+ ~HTTPSOCSPTest() override {
#if defined(USE_NSS) || defined(OS_IOS)
ShutdownNSSHttpIO();
#endif
