Google Git
Sign in
chromium / chromium / src.git / 6b7727d6aa692cf35687b7d7277c6b321380dc65
commit6b7727d6aa692cf35687b7d7277c6b321380dc65[log] [tgz]
authorDmitry Gozman <[email protected]>Mon May 06 18:30:24 2019
committerCommit Bot <[email protected]>Mon May 06 18:30:24 2019
tree9b236da69a78aa52f42937f022e5bb9d84110a34
parent22ec7a111842a65e8f5a818f65453206d4ab5ca0 [diff]
Replace placeholder document loader with a struct

Placeholder document loader is set while navigation is happening in the
browser process (through CreatePlaceholderDocumentLoader).

It does not ever load the document, and just sits around to:
- act as a flag that navigation is ongoing;
- fire DidFailProvisionalLoad callback when detaching;
- be used mistakenly by some calls to GetProvisionalDocumentLoader().

This patch replaces placeholder document loader with
FrameLoader::client_navigation_ struct, and clears/cancels it next to
provisional_document_loader_. Some GetProvisionalDocumentLoader callsites
are updated to use |browser_side_navigation_pending_| instead, because
these are interested in "whether navigation is ongoing", and we don't have
placeholder DL to be returned from GetProvisionalDocumentLoader anymore.

Somehow this change exposes flakiness in
external/wpt/resource-timing/nested-context-navigations-iframe.html, which
relies on racy should_send_resource_timing_info_to_parent flag being sent
across processes. See DocumentLoader::ShouldReportTimingInfoToParent
for more details.

This corresponds to step 12 from the doc linked to the bug.

Bug: 855189, 957181
Change-Id: I5a10b283012f2000aa36a5748bbd412a31362347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573813
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Dmitry Gozman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#656879}
12 files changed
tree: 9b236da69a78aa52f42937f022e5bb9d84110a34
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .