Reland of Trigger Dangerous indicator for unsafe subresources (patchset #1 id:1 of https://codereview.chromium.org/2461093002/ )
Reason for revert:
Broke build, https://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/89477/steps/compile/logs/stdio
Original issue's description:
> Revert of Trigger Dangerous indicator for unsafe subresources (patchset #4 id:60001 of https://codereview.chromium.org/2444383007/ )
>
> Reason for revert:
> Breaks MSan tests:
>
> First breaking build:
> https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests/builds/2755
>
> Original issue's description:
> > Trigger Dangerous indicator for unsafe subresources
> >
> > Previously, the Dangerous indicator was not firing for subresources
> > flagged by Safe Browsing as unsafe. This is because marking a
> > subresource as unsafe was not triggering an omnibox update. We want to
> > trigger an omnibox update whenever a URL is marked as
> > whitelisted (either pending, meaning that an interstitial is showing, or
> > whitelisted, meaning that an interstitial has been clicked through) in
> > SafeBrowsingUIManager.
> >
> > To do so, this CL renames WebContentsImpl::DidChangeVisibleSSLState() to
> > DidChangeVisibleSecurityState() (since it's no longer just SSL
> > information that can affect the omnibox security UI) and moves it to
> > WebContents so that it can be called from SafeBrowsingUIManager.
> >
> > BUG=659713
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> >
> > Committed: https://crrev.com/8bb181295c47ba4d74a626f809a1a27423544f2f
> > Cr-Commit-Position: refs/heads/master@{#428223}
>
> [email protected],[email protected],[email protected]
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=659713
>
> Committed: https://crrev.com/201e61b48c2f4ee497ca1fc09217ad8a190b829b
> Cr-Commit-Position: refs/heads/master@{#428520}
[email protected],[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659713
Review-Url: https://codereview.chromium.org/2454393003
Cr-Commit-Position: refs/heads/master@{#428534}
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 53b04ae..3bd26d1 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -183,9 +183,6 @@
// plugins it is hosting.
void CancelActiveAndPendingDialogs();
- // Invoked when visible SSL state (as defined by SSLStatus) changes.
- void DidChangeVisibleSSLState();
-
// Informs the render view host and the BrowserPluginEmbedder, if present, of
// a Drag Source End.
void DragSourceEndedAt(int client_x, int client_y, int screen_x,
@@ -337,6 +334,7 @@
void AttachToOuterWebContentsFrame(
WebContents* outer_web_contents,
RenderFrameHost* outer_contents_frame) override;
+ void DidChangeVisibleSecurityState() override;
void Stop() override;
WebContents* Clone() override;
void ReloadFocusedFrame(bool bypass_cache) override;
