Don't double-call VLOG_IS_ON for DVLOG
VLOG (and VPLOG) already check VLOG_IS_ON, so there is no need to check
for that condition again in DVLOG/DVPLOG.
Also updated the comment about why VLOG is slow.
Change-Id: I52ff48fa0f90414d49ce248deaec8aeb67bdd89b
Reviewed-on: https://chromium-review.googlesource.com/c/1408128
Reviewed-by: danakj <[email protected]>
Commit-Queue: Kenneth MacKay <[email protected]>
Cr-Commit-Position: refs/heads/master@{#622916}diff --git a/base/logging.h b/base/logging.h
index 741f428..67f4632 100644
--- a/base/logging.h
+++ b/base/logging.h
@@ -416,8 +416,8 @@
#define LOG_IS_ON(severity) \
(::logging::ShouldCreateLogMessage(::logging::LOG_##severity))
-// We can't do any caching tricks with VLOG_IS_ON() like the
-// google-glog version since it requires GCC extensions. This means
+// We don't do any caching tricks with VLOG_IS_ON() like the
+// google-glog version since it increases binary size. This means
// that using the v-logging functions in conjunction with --vmodule
// may be slow.
#define VLOG_IS_ON(verboselevel) \
@@ -854,9 +854,9 @@
#define DPLOG(severity) \
LAZY_STREAM(PLOG_STREAM(severity), DLOG_IS_ON(severity))
-#define DVLOG(verboselevel) DVLOG_IF(verboselevel, VLOG_IS_ON(verboselevel))
+#define DVLOG(verboselevel) DVLOG_IF(verboselevel, true)
-#define DVPLOG(verboselevel) DVPLOG_IF(verboselevel, VLOG_IS_ON(verboselevel))
+#define DVPLOG(verboselevel) DVPLOG_IF(verboselevel, true)
// Definitions for DCHECK et al.
