Change crypto::ECSignatureCreator::Sign to take in a span
Bug: 830085
Change-Id: I39d1dd92a3c8bb11da54f6530b0cc0f583a4dc8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3035129
Reviewed-by: Josh Nohle <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Reviewed-by: Martin Rodriguez <[email protected]>
Reviewed-by: Michael van Ouwerkerk <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
Commit-Queue: Hubert Chao <[email protected]>
Cr-Commit-Position: refs/heads/master@{#903939}
diff --git a/crypto/ec_signature_creator_impl.cc b/crypto/ec_signature_creator_impl.cc
index d7da650..c5a89d0b 100644
--- a/crypto/ec_signature_creator_impl.cc
+++ b/crypto/ec_signature_creator_impl.cc
@@ -24,8 +24,7 @@
ECSignatureCreatorImpl::~ECSignatureCreatorImpl() = default;
-bool ECSignatureCreatorImpl::Sign(const uint8_t* data,
- int data_len,
+bool ECSignatureCreatorImpl::Sign(base::span<const uint8_t> data,
std::vector<uint8_t>* signature) {
OpenSSLErrStackTracer err_tracer(FROM_HERE);
bssl::ScopedEVP_MD_CTX ctx;
@@ -33,7 +32,7 @@
if (!ctx.get() ||
!EVP_DigestSignInit(ctx.get(), nullptr, EVP_sha256(), nullptr,
key_->key()) ||
- !EVP_DigestSignUpdate(ctx.get(), data, data_len) ||
+ !EVP_DigestSignUpdate(ctx.get(), data.data(), data.size()) ||
!EVP_DigestSignFinal(ctx.get(), nullptr, &sig_len)) {
return false;
}
