| commit | 7296440c1b81781ff2c2a2a187a240d341c2d9d1 | [log] [tgz] |
|---|---|---|
| author | Ken Rockot <[email protected]> | Fri Dec 06 10:40:51 2019 |
| committer | Commit Bot <[email protected]> | Fri Dec 06 10:40:51 2019 |
| tree | 121a263c7a346c4c95a6c56d416531a8659bd284 | |
| parent | deb66a71a2c3ec09be3067035aaec6b558c9ebcc [diff] [blame] |
Reland "Reland "Move Audio Service off Service Manager"" This is a reland of e8d24f737e29f3fba3e4654ea1dc1259e1373058 Original change's description: > Reland "Move Audio Service off Service Manager" > > This is a reland of a4d27f513eb40a89505f042d68693ed6702400d9 > > The reland moves the TestingApi binder support into a component > library to avoid duplicate definitions that resulted in browser > test failures in component builds. > > Original change's description: > > Move Audio Service off Service Manager > > > > All the details around if/when a service instance is started and whether > > it's in- or out-of-process have been centralized into the implementation > > of a single GetAudioService() helper in Content. > > > > A few other helpers are added to ease the transition off the Service > > Manager, though they aren't necessarily ideal APIs. For example, > > client library APIs which once took a Service Manager Connector may now > > take a RepeatingCallback to bind a specific type of interface. > > > > In addition to GetAudioService(), Content provides helpers for > > AudioSystem construction and StreamFactory binding from any sequence. > > > > Because all timeout/lifetime management logic is now generically > > supported within Mojo and Content and requires no service implementation > > details to get right (and because unit tests launching service processes > > is no longer supported outside of Content), all Audio Service test > > coverage relevant to lifetime management is deemed superfluous and has > > been removed. > > > > Bug: 977637 > > Change-Id: I4c59948eafce2322547bf2b0479961e095b3edee > > Tbr: [email protected] > > Tbr: [email protected] > > Tbr: [email protected] > > Tbr: [email protected] > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941280 > > Commit-Queue: Ken Rockot <[email protected]> > > Reviewed-by: Dale Curtis <[email protected]> > > Reviewed-by: Avi Drissman <[email protected]> > > Reviewed-by: Robert Sesek <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#721832} > > Bug: 977637 > Change-Id: I183e79042c99458f2abf9423d8f9bbefedf5b374 > No-Presubmit: true > Tbr: [email protected] > Tbr: [email protected] > Tbr: [email protected] > Tbr: [email protected] > Tbr: [email protected] > Tbr: [email protected] > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952601 > Reviewed-by: Avi Drissman <[email protected]> > Reviewed-by: Dale Curtis <[email protected]> > Commit-Queue: Ken Rockot <[email protected]> > Cr-Commit-Position: refs/heads/master@{#722373} Bug: 977637 Change-Id: I1b803e57632bd92f2b1e093c3d1c1731de8338f0 No-Presubmit: true Tbr: [email protected] Tbr: [email protected] Tbr: [email protected] Tbr: [email protected] Tbr: [email protected] Tbr: [email protected] Tbr: [email protected] Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954772 Reviewed-by: Ken Rockot <[email protected]> Commit-Queue: Ken Rockot <[email protected]> Cr-Commit-Position: refs/heads/master@{#722428}
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc index 6f2ee55..a9e3c21e 100644 --- a/content/browser/web_contents/web_contents_impl.cc +++ b/content/browser/web_contents/web_contents_impl.cc
@@ -7136,7 +7136,7 @@ ? static_cast<media::UserInputMonitorBase*>( BrowserMainLoop::GetInstance()->user_input_monitor()) : nullptr, - GetSystemConnector()->Clone(), AudioStreamBrokerFactory::CreateImpl()); + AudioStreamBrokerFactory::CreateImpl()); } return &*audio_stream_factory_;