Refactor QuicStreamFactory constructor
About two thirds of QuicStreamFactory's constructor's arguments were
copied in from the HttpNetworkSession::Params. This CL moves most QUIC
related params from HttpNetworkSession::Params to a new QuicParams
struct. The arguments to the QuicStreamFactory constructor that were
copied from HttpNetworkSession::Params are now replaced by a single
QuicParams struct, as are many of the member variables of
QuicStreamFactory.
Bug: 980654
Change-Id: I0a65e5eb5d0bfe22ba49afcca75387c1c984dc5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695738
Reviewed-by: Ryan Hamilton <[email protected]>
Reviewed-by: Robbie McElrath <[email protected]>
Commit-Queue: Nick Harper <[email protected]>
Cr-Commit-Position: refs/heads/master@{#678113}
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index e88fd253..0745934 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -12195,7 +12195,7 @@
base::Time expiration = base::Time::Now() + base::TimeDelta::FromDays(1);
http_server_properties->SetQuicAlternativeService(
test_server, alternative_service, expiration,
- session->params().quic_supported_versions);
+ session->params().quic_params.supported_versions);
EXPECT_EQ(
1u,
http_server_properties->GetAlternativeServiceInfos(test_server).size());
@@ -12348,7 +12348,7 @@
base::Time expiration = base::Time::Now() + base::TimeDelta::FromDays(1);
http_server_properties->SetQuicAlternativeService(
server, alternative_service, expiration,
- HttpNetworkSession::Params().quic_supported_versions);
+ HttpNetworkSession::Params().quic_params.supported_versions);
// Mark the QUIC alternative service as broken.
http_server_properties->MarkAlternativeServiceBroken(alternative_service);
@@ -12413,12 +12413,12 @@
alternative_service_info_vector.push_back(
AlternativeServiceInfo::CreateQuicAlternativeServiceInfo(
alternative_service1, expiration,
- session->params().quic_supported_versions));
+ session->params().quic_params.supported_versions));
AlternativeService alternative_service2(kProtoQUIC, alternative2);
alternative_service_info_vector.push_back(
AlternativeServiceInfo::CreateQuicAlternativeServiceInfo(
alternative_service2, expiration,
- session->params().quic_supported_versions));
+ session->params().quic_params.supported_versions));
http_server_properties->SetAlternativeServices(
server, alternative_service_info_vector);